TB9.0a7 is asking for a new profile

After installing the new alpha in MacOS Mojave v10.14, a New Profile box was prompted. Screenshot attached.

added TorBrowserTeam201910R actualpoints::0.25 component::applications/tor browser owner::mcs points::0.5 priority::high resolution::fixed severity::normal status::closed tbb-9.0-must type::defect labels

Trac:

Where did you put your browser? Into /Applications? And that's not been caused by an update but a new installation?

Trac:
Status: new to needs_information
Priority: Medium to High
Keywords: N/A deleted, TorBrowserTeam201910, tbb-9.0-must added
Points: N/A to 0.5

No. I installed it from the /download folder, and yes, it went to /Applications. When I opened it, the popup got prompted.

No update, fresh install.

Do you know which version was installed previously in /Applications?

8.5 8.5.4 9.0a3 9.0a4 9.0a6 9.0a7 a few tbb-nightly

:/

Let me try again in a fresh environment, and back to this ticket.

No worries. I was interested in the one immediately before you put the new version over it as I was trying to reproduce your error.

good question! It was a custom nighly made by pospeselr for me, probably without the patch that fixes that problem.

Kathy and I saw this same prompt while working on #31607 (moved); we were reusing various TorBrowser-Data directories in an attempt to better understand the causes for that bug. I had it on my TODO list to file a ticket but now Antonela did it for me :)

Since Tor Browser does not support more than one profile, we should disable this prompt and related code. We can do that by changing a MOZ_BLOCK_PROFILE_DOWNGRADE configure option from True to False. This is similar to what we did for #31457 (moved) and in fact the options are right next to each other in browser/moz.configure.

Trac:
Owner: tbb-team to mcs
Cc: mcs, brade to mcs, brade, tbb-team
Status: needs_information to assigned

Here is a patch for this issue: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug31935-01&id=d375c811357fc32f7f0d2e399ebb9edb2764eb76

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R added

Looks good. Merged to tor-browser-68.1.0esr-9.0-2 (commit d375c811357fc32f7f0d2e399ebb9edb2764eb76).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Actualpoints: N/A to 0.25

closed

changed time estimate to 4h

added 2h of time spent

moved to tpo/applications/tor-browser#31935 (closed)