Opened 8 months ago

Closed 6 months ago

#31939 closed defect (fixed)

log spam: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed.

Reported by: catalyst Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.4-rc
Severity: Normal Keywords: consider-backport-after-0424, assert, fast-fix, 042-should, 035-backport, 040-backport, 041-backport, BugSmashFund
Cc: Actual Points: 0.1
Parent ID: #32022 Points: 0.1
Reviewer: catalyst Sponsor:

Description

Nonfatal assert log spamming as seen in #31036.

Jun 26 07:01:30.000 [warn] {BUG} tor_bug_occurred_(): Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT
#_MAX - at_most) failed. (on Tor 0.4.0.5 )

(I assume the # in the middle of INT_MAX is a paste/transcription artifact, but then again it might not be.)

Child Tickets

Change History (11)

comment:1 Changed 8 months ago by teor

Keywords: fast-fix 042-should added
Milestone: Tor: unspecifiedTor: 0.4.2.x-final
Owner: set to teor
Status: newassigned

We can do a quick fix for this issue using BUG_ONCE().
We should also backport that change.

comment:2 Changed 8 months ago by teor

Actual Points: 0.1
Keywords: 035-backport 040-backport 041-backport BugSmashFund added
Parent ID: #31036
Points: 0.1
Status: assignedneeds_review
Version: Tor: 0.3.0.4-rc

The # appears to be a copy-paste error, the log appears without that typo later in #31036.

See my PR:

The merge forward had no conflicts, the test branches are here:

comment:3 Changed 8 months ago by nickm

+1 on this, but we should also think a little about _why_ this might be happening.

comment:4 Changed 8 months ago by dgoulet

Reviewer: catalyst

comment:5 Changed 8 months ago by catalyst

Parent ID: #31036#32022
Summary: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed.log spam: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed.

Reparent to #32022

comment:6 in reply to:  3 Changed 8 months ago by catalyst

Replying to nickm:

+1 on this, but we should also think a little about _why_ this might be happening.

Opened #32022 (which is now the parent of this ticket) for the underlying problem.

comment:7 in reply to:  2 Changed 8 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to teor:

See my PR:

The merge forward had no conflicts, the test branches are here:

Thanks; these look good!

comment:8 Changed 8 months ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.1.x-final

Merged to master, marking for backport.

comment:9 Changed 8 months ago by teor

Keywords: consider-backport-after-0424 added

comment:10 in reply to:  description Changed 6 months ago by cypherpunks

Replying to catalyst:

(I assume the # in the middle of INT_MAX is a paste/transcription artifact, but then again it might not be.)

ignore this

#

it is not there actually looks like:

Nov 24 07:14:18.000 [warn] {BUG} Bug: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed in buf_read_from_tls at buffers_tls.c:73. (Stack trace not available) (on Tor 0.4.1.6 )
Nov 24 07:14:18.000 [warn] {BUG} tor_bug_occurred_(): Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed. (Future instances of this warning will be silenced.) (o
n Tor 0.4.1.6 )

comment:11 Changed 6 months ago by teor

Milestone: Tor: 0.4.1.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.5 and later.

Merged #32575, #31939, #31548, #30344, #30258, #28970, #31091, and #32108 together.

Note: See TracTickets for help on using tickets.