log spam: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed.

changed milestone to %Tor: 0.3.5.x-final

Trac:
Parent Ticket: #32022 (moved)

added 035-backport 040-backport 041-backport 042-should BugSmashFund actualpoints::0.1 assert component::core tor/tor consider-backport-after-0424 fast-fix milestone::Tor: 0.3.5.x-final owner::teor parent::32022 points::0.1 priority::medium resolution::fixed reviewer::catalyst severity::normal status::closed type::defect version::tor 0.3.0.4-rc labels

We can do a quick fix for this issue using BUG_ONCE(). We should also backport that change.

Trac:
Keywords: N/A deleted, 042-should, fast-fix added
Status: new to assigned
Milestone: Tor: unspecified to Tor: 0.4.2.x-final
Owner: N/A to teor

The # appears to be a copy-paste error, the log appears without that typo later in #31036 (moved).

See my PR:

0.3.5: https://github.com/torproject/tor/pull/1394

The merge forward had no conflicts, the test branches are here:

https://github.com/teor2345/tor/branches/all?query=31939

Trac:
Keywords: N/A deleted, 041-backport, 035-backport, BugSmashFund, 040-backport added
Actualpoints: N/A to 0.1
Version: N/A to Tor: 0.3.0.4-rc
Points: N/A to 0.1
Status: assigned to needs_review
Parent: N/A to #31036 (moved)

+1 on this, but we should also think a little about why this might be happening.

Trac:
Reviewer: N/A to catalyst

Reparent to #32022 (moved)

Trac:
Summary: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed. to log spam: Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed.
Parent: #31036 (moved) to #32022 (moved)

Replying to nickm:

+1 on this, but we should also think a little about why this might be happening. Opened #32022 (moved) (which is now the parent of this ticket) for the underlying problem.

Replying to teor:

See my PR:

0.3.5: https://github.com/torproject/tor/pull/1394

The merge forward had no conflicts, the test branches are here:

https://github.com/teor2345/tor/branches/all?query=31939 Thanks; these look good!

Trac:
Status: needs_review to merge_ready

Merged to master, marking for backport.

Trac:
Milestone: Tor: 0.4.2.x-final to Tor: 0.4.1.x-final

Trac:
Keywords: N/A deleted, consider-backport-after-0424 added

Replying to catalyst:

(I assume the # in the middle of INT_MAX is a paste/transcription artifact, but then again it might not be.)

ignore this

it is not there actually looks like:

Nov 24 07:14:18.000 [warn] {BUG} Bug: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed in buf_read_from_tls at buffers_tls.c:73. (Stack trace not available) (on Tor 0.4.1.6 )
Nov 24 07:14:18.000 [warn] {BUG} tor_bug_occurred_(): Bug: buffers_tls.c:73: buf_read_from_tls: Non-fatal assertion !(buf->datalen >= INT_MAX - at_most) failed. (Future instances of this warning will be silenced.) (o
n Tor 0.4.1.6 )