Opened 8 months ago

Last modified 13 days ago

#31940 accepted enhancement

Fail unit tests that hang

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-unit-tests, 043-can
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Follow up to #31841.

We should set a time limit for each individual unit test, and fail it if it takes too long.

We might also want to timelimit checks as well.

We can set a time limit on entire shell commands using the "timelimit" command. But we will need to write test code to do it per-unit test.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by teor

Keywords: 043-should removed

Maybe we don't need to do this if our other fixes work.

comment:2 Changed 4 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:3 Changed 4 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 4 months ago by nickm

Keywords: 043-can added; 043-deferred removed

comment:5 Changed 13 days ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

0.4.3 was released: Move non merge-ready 0.4.3 tickets to 044.

Note: See TracTickets for help on using tickets.