Opened 6 weeks ago

Closed 4 weeks ago

#31955 closed defect (fixed)

macOS: avoid throwing inside nonBrowserWindowStartup()

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910R, tbb-9.0-must
Cc: Actual Points: 0.25
Parent ID: Points: 1
Reviewer: Sponsor:

Description

On macOS, opening the Page Info window and other "non browser windows" causes a message like this to appear on the Browser Console:

TypeError: document.getElementById(...) is null nonbrowser-mac.js:105:14

This happens because the code inside the nonBrowserWindowStartup() function (in browser/base/content/nonbrowser-mac.js) is blindly looking for a DOM element that is only present in the Mac hidden window. Kathy and I have a patch for this which we should try to upstream to Firefox as well.

Child Tickets

Change History (4)

comment:1 Changed 6 weeks ago by mcs

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

comment:2 Changed 6 weeks ago by gk

Looks good. Cherry-picked to tor-browser-68.1.0esr-9.0-2 (commit 7ad264c14007eaa870db55eba82b1e32faf299bf). Please file the Mozilla ticket and then close this bug, thanks!

comment:3 Changed 5 weeks ago by mcs

Actual Points: 0.25

comment:4 Changed 4 weeks ago by mcs

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.