Skip to content
Snippets Groups Projects
New look: Off

TOPL: Sort dependency list

    • Closed (moved) Issue created by Shane Isbell @sisbell

    Sort dependency list and follow latest how to update gradle dependencies instructions.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Trac
      Trac @tracbot ·

      Trac:
      Parent Ticket: #30324 (moved)

    • Shane Isbell added TorBrowserTeam201910 component::applications/tor browser ff68-esr owner::tbb-team parent::30324 priority::medium resolution::fixed severity::normal status::closed tbb-9.0-must-alpha tbb-rbm type::defect labels

      added TorBrowserTeam201910 component::applications/tor browser ff68-esr owner::tbb-team parent::30324 priority::medium resolution::fixed severity::normal status::closed tbb-9.0-must-alpha tbb-rbm type::defect labels

    • S
      Shane Isbell @sisbell ·
      Author

      This is from https://trac.torproject.org/projects/tor/ticket/30460#comment:14

    • S
      Shane Isbell @sisbell ·
      Author

      I regenerated the list of dependencies using the exact instructions in the updated projects/common/how-to-create-gradle-dependencies-list.txt file. I also verified that firefox and tor-android-service projects already have the dependencies file generated from these instructions.

      https://github.com/sisbell/tor-browser-build/commit/e5d93174b0f7e40511fd74dc72fe167e47147d20

      Trac:
      Status: new to needs_review

    • Georg Koppen
      Georg Koppen @gk ·

      Replying to sisbell:

      I regenerated the list of dependencies using the exact instructions in the updated projects/common/how-to-create-gradle-dependencies-list.txt file. I also verified that firefox and tor-android-service projects already have the dependencies file generated from these instructions.

      https://github.com/sisbell/tor-browser-build/commit/e5d93174b0f7e40511fd74dc72fe167e47147d20

      Do we really need to bump gradle_dependencies_version? After all it's just a sorting of dependencies which should not affect the gradle dependencies themselves.

      Trac:
      Status: needs_review to needs_information

    • Georg Koppen
      Georg Koppen @gk ·

      Alright. Looking at gradle-dependencies-list.txt as we have it on master results in 277 entries we need to download. Looking at the same file in your branch after sorting results in 313 entries to download. So, there is something going wrong here. If we only need 277 entries to build (TOPL) then we should take those (maybe we need even less). Either way, this needs revision.

      Trac:
      Status: needs_information to needs_revision

    • S
      Shane Isbell @sisbell ·
      Author

      Replying to gk:

      Alright. Looking at gradle-dependencies-list.txt as we have it on master results in 277 entries we need to download. Looking at the same file in your branch after sorting results in 313 entries to download. So, there is something going wrong here. If we only need 277 entries to build (TOPL) then we should take those (maybe we need even less). Either way, this needs revision.

      The resolver can download more than it actually needs at compile time. So its possible that it needs less. I can look at what's going on with the extra entries but the method used to generate the lists from the logs is different between these two lists.

    • S
      Shane Isbell @sisbell ·
      Author

      I believe this contains the command that generated 277

      https://github.com/sisbell/tor-browser-build/commit/221348850ecacda7c6eac7681603b720adb14f5e

    • S
      Shane Isbell @sisbell ·
      Author

      I checked the method I was using in August (from the link below) and it generates 493 URLs from the logs. The program I use for downloading and creating the gradle-dependency list downloads 313. So the most recent method and the method is August match. So 313 is the correct count. 277 must have come from some earlier version that I was working in (possibly different gradle plugin/version) entirely.

      Replying to sisbell:

      I believe this contains the command that generated 277

      https://github.com/sisbell/tor-browser-build/commit/221348850ecacda7c6eac7681603b720adb14f5e

    • S
      Shane Isbell @sisbell ·
      Author

      Its interesting that the additional dependencies are all from the android tools. Things like ddms are obviously not used.

      Checking the dependencies of the gradle plugin 3.1, we can see these additional ones are being pulled in by the android gradle plugin.

      https://android.googlesource.com/platform/prebuilts/gradle-plugin/+/6ef3f69959e89df946045097d84a3502c64a18c1

      So the 313 count looks correct.

       https://repo.spring.io/plugins-release/com/android/tools/analytics-library/protos/26.1.0/protos-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/analytics-library/protos/26.1.0/protos-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/analytics-library/shared/26.1.0/shared-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/analytics-library/shared/26.1.0/shared-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/analytics-library/tracker/26.1.0/tracker-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/analytics-library/tracker/26.1.0/tracker-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/annotations/26.1.0/annotations-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/annotations/26.1.0/annotations-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/apksig/3.1.0/apksig-3.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/apksig/3.1.0/apksig-3.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/builder-model/3.1.0/builder-model-3.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/builder-model/3.1.0/builder-model-3.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/builder-test-api/3.1.0/builder-test-api-3.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/builder-test-api/3.1.0/builder-test-api-3.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/builder/3.1.0/builder-3.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/builder/3.1.0/builder-3.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/gradle-api/3.1.0/gradle-api-3.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/gradle-api/3.1.0/gradle-api-3.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/build/manifest-merger/26.1.0/manifest-merger-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/build/manifest-merger/26.1.0/manifest-merger-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/common/26.1.0/common-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/common/26.1.0/common-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/ddms/ddmlib/26.1.0/ddmlib-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/ddms/ddmlib/26.1.0/ddmlib-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/dvlib/26.1.0/dvlib-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/dvlib/26.1.0/dvlib-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/layoutlib/layoutlib-api/26.1.0/layoutlib-api-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/layoutlib/layoutlib-api/26.1.0/layoutlib-api-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/lint/lint-gradle-api/26.1.0/lint-gradle-api-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/lint/lint-gradle-api/26.1.0/lint-gradle-api-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/repository/26.1.0/repository-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/repository/26.1.0/repository-26.1.0.pom
 https://repo.spring.io/plugins-release/com/android/tools/sdk-common/26.1.0/sdk-common-26.1.0.jar
 https://repo.spring.io/plugins-release/com/android/tools/sdk-common/26.1.0/sdk-common-26.1.0.pom
    • S
      Shane Isbell @sisbell ·
      Author

      So the logs to tor-onion-proxy was unique in the sense it does download the same artifact twice from two different locations. These downloads occur on different threads so I think one resolver is unaware of what the other resolver is doing.

      To be able to remove these duplicates, we do need to rev the characters in each line that then match multiple fields (since artifacts with different groupIds have the same artifact name and version). So I added that to the documentation and tested it out. We are back to the 277 artifacts after this.

      https://github.com/sisbell/tor-browser-build/commit/b68e087cc157920c3af14cd82b6047f7d5c6e13b

    • S
      Shane Isbell @sisbell ·
      Author

      Trac:
      Status: needs_revision to needs_review

    • Georg Koppen
      Georg Koppen @gk ·

      The sorted result looks good to me. Cherry-picked to master (commit 8b1f9f1e655ed7cad832d8bfe2d1ee617231688e), thanks.

      Trac:
      Resolution: N/A to fixed
      Status: needs_review to closed

    • Trac closed

      closed

    • Trac mentioned in issue #30324 (moved)

      mentioned in issue #30324 (moved)

    • Trac moved to tpo/applications/tor-browser#31979 (closed)

      moved to tpo/applications/tor-browser#31979 (closed)

    Please register or sign in to reply