Opened 6 weeks ago

Closed 6 weeks ago

#31995 closed defect (fixed)

test fail: assert(ip->time_to_expire OP_GE now + INTRO_POINT_LIFETIME_MIN_SECONDS

Reported by: asn Owned by: asn
Priority: High Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-test tor-hs 042-must nickm-merge
Cc: Actual Points: 0.2
Parent ID: Points: 0.3
Reviewer: dgoulet Sponsor:

Description

weasel reported a test failing for debian:
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=mipsel&ver=0.4.2.1-alpha-1&stamp=1569200155&raw=0

hs_service/service_intro_point: [forking] 
  FAIL ../src/test/test_hs_service.c:694: assert(ip->time_to_expire OP_GE now + INTRO_POINT_LIFETIME_MIN_SECONDS - 500): 1569262226 vs 1569262632
  [service_intro_point FAILED]

this seems to have occured before in #25450 and #27810 and it's still unfixed :/

Child Tickets

Change History (6)

comment:1 Changed 6 weeks ago by nickm

Priority: MediumHigh

comment:2 Changed 6 weeks ago by dgoulet

Owner: set to asn
Reviewer: dgoulet
Status: newassigned

comment:3 Changed 6 weeks ago by asn

Status: assignedneeds_review

OK here is the current theory:

The HS intro point code uses approx_time() as its timing source, but the test never actually updates approx_time(). This means that approx_time() is stuck to the old value, and if tests run very slow it can get majorly from time(NULL).

Please see https://github.com/torproject/tor/pull/1399

comment:4 Changed 6 weeks ago by asn

Actual Points: 0.30.2
Points: 0.3

comment:5 Changed 6 weeks ago by dgoulet

Keywords: nickm-merge added
Status: needs_reviewmerge_ready

lgtm!

comment:6 Changed 6 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master!

Note: See TracTickets for help on using tickets.