Opened 4 months ago

Closed 3 months ago

#32000 closed defect (fixed)

stem: test_with_ephemeral_hidden_services_basic_auth failing

Reported by: dgoulet Owned by: atagar
Priority: Medium Milestone:
Component: Archived/Stem Version:
Severity: Normal Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#29669 was merged to tor.git master yesterday and so this test now is failing.

Reason is that now ADD_ONION NEW:BEST defaults to v3 and the test seems to use client authorization v2 with it:

ADD_ONION response didn't have an OK status: ClientAuth not supported

It probably could be that stem needs to change things within the API call: create_ephemeral_hidden_service() with regards to its basic_auth parameter?

Child Tickets

Change History (2)

comment:1 Changed 3 months ago by atagar

Hi David. Here's the request/reply being issued by the test...

10/08/2019 14:01:57 [TRACE] Sent to tor: ADD_ONION NEW:BEST Flags=BasicAuth Port=4567 ClientAuth=bob ClientAuth=alice:nKwfvVPmTNr2k2pG0pzV4g
10/08/2019 14:01:57 [TRACE] Received from tor: 513 ClientAuth not supported

ClientAuth is part of the control specification...

https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n1593

Did we break backward compatibility? And is this ADD_ONION change violating tor's spec? I'd be happy to adjust the test but on first glance this looks like a legitimate test failure that should make us rethink the tor commit.

comment:2 Changed 3 months ago by atagar

Resolution: fixed
Status: newclosed

Stem test adjusted to pass: https://gitweb.torproject.org/stem.git/commit/?id=eff0664

Thanks for pointing this out!

Note: See TracTickets for help on using tickets.