Unify handling of command-line option parsing

Our function for parsing the command line does not actually set up various command-line-only options, leaving that to be done elsewhere. We should make this table-driven, so we can simplify our code.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #29211 (moved)

added actualpoints::.4 component::core tor/tor milestone::Tor: 0.4.3.x-final network-team-roadmap-august owner::nickm parent::29211 points::.4 priority::medium resolution::implemented reviewer::teor severity::normal sponsor::31-can status::closed type::task labels

branch is cmdline_refactor with PT at https://github.com/torproject/tor/pull/1400. I'll wait for CI and coverage before I merge_ready.

CI has passed; I've squashed some fixups, split a commit, and re-pushed. Putting in needs_review under the presumption it will pass again.

Trac:
Status: assigned to needs_review

I didn't do a full review here, but I noticed a typo in a comment.

Trac:
Reviewer: N/A to teor

I added some comments on the PR.

Do we need more command-line tests? We might not need a test for every option, but one per mode/quiet level would be nice.

Trac:
Status: needs_review to needs_revision

I've made the requested changes. For the quiet levels, I think I can do that, but what do you mean by "mode"?

I'd hoped that the existing tests might be enough for this patch, since they cover 100% of affected lines; I'd be okay with writing more, though.

Trac:
Status: needs_revision to needs_review

Ok, if we have 100% coverage, we don't need more tests.

There's one fix remaining: the CMD_OTHER rename didn't reach the nt_service files: https://ci.appveyor.com/project/torproject/tor/builds/28177080/job/svbqubudyuw6c38i#L3075

When that's fixed, and CI passes, feel free to merge this ticket.

ok, pushed a fix and waiting for CI.

(To be clear, the 100% coverage is on the lines modified by this branch; I hope that's ok)

CI passed; squashed and merging.

Trac:
Resolution: N/A to implemented
Status: needs_review to closed
Actualpoints: .3 to .4

closed

changed time estimate to 3h 12m

added 3h 12m of time spent

mentioned in issue #29211 (moved)

moved to tpo/core/tor#32003 (closed)