Opened 4 months ago

Closed 4 months ago

#32018 closed defect (fixed)

Remove unicode Character 'NO-BREAK SPACE' (U+00A0) from fp-central/run.py

Reported by: boklm Owned by: boklm
Priority: Low Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Minor Keywords: fpcentral, TorBrowserTeam201910R, boklm201910
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

When running run.py with python2 instead of python3, I noticed that it gets confused by the use of Non-ASCII characters:

SyntaxError: Non-ASCII character '\xc2' in file /srv/fpcentral.tbb.torproject.org/fpcentral/run.py on line 302, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

As we don't really need those special characters, I think we can replace them with ascii whitespaces.

Child Tickets

Change History (3)

comment:1 Changed 4 months ago by boklm

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

comment:2 Changed 4 months ago by boklm

Priority: MediumLow
Severity: NormalMinor

comment:3 in reply to:  1 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to boklm:

There is a patch in my branch bug_32018:
https://gitweb.torproject.org/user/boklm/fpcentral.git/commit/?h=bug_32018&id=aee05b9a67d1127920b07de65598b4302e2d88d5

Looks good. Merged to master (commit aee05b9a67d1127920b07de65598b4302e2d88d5).

Note: See TracTickets for help on using tickets.