Opened 5 weeks ago

Closed 4 weeks ago

#32046 closed enhancement (fixed)

Stop counting handlers

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: cohosh Sponsor:

Description

The transport programs (client, server, and server-webrtc) have some obsolete handler-counting code that tries to keep the process alive until all ongoing connections have terminated. This is a remnant of an earlier version of pt-spec that prescribed different handling of SIGINT and SIGTERM, and required this behavior on SIGTERM. pt-spec has since changed to no longer mention SIGINT, and prescribe immediate shutdown (terminating ongoing handlers) on SIGTERM.

Here's background: comment:5:ticket:26389.

Here's the corresponding change in meek: https://gitweb.torproject.org/pluggable-transports/meek.git/commit/?id=c7541223c704f76cb45a4e20bd20d963ea8d1fc7

Child Tickets

Attachments (1)

0001-Stop-counting-handlers-before-terminating.patch (4.8 KB) - added by dcf 5 weeks ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 weeks ago by dcf

Status: assignedneeds_review

comment:2 Changed 5 weeks ago by cohosh

Reviewer: cohosh

comment:3 Changed 5 weeks ago by cohosh

Status: needs_reviewmerge_ready

This patch looks good to me.

Note: See TracTickets for help on using tickets.