Opened 4 weeks ago

Closed 4 weeks ago

#32061 closed defect (fixed)

Bump snowflake to b4f4b29a03

Reported by: cohosh Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: snowflake TorBrowserTeam201910R
Cc: dcf, phw, cohosh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by dcf)

Includes merge of pion branch to master (#28942) and removal of handler counting code (#32046).

This will solve the build failure in #32066.

Child Tickets

Attachments (2)

0001-bump-snowflake-version-to-b4f4b29a03.patch (799 bytes) - added by cohosh 4 weeks ago.
0001-bump-snowflake-version-to-b4f4b29a03.2.patch (875 bytes) - added by cohosh 4 weeks ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 weeks ago by cohosh

Status: newneeds_review

comment:2 Changed 4 weeks ago by dcf

Description: modified (diff)
Keywords: TorBrowserTeam201910R added

Looks right to me. (I also hit the build failure in #32066 today.)

comment:3 Changed 4 weeks ago by dcf

Oh, but shouldn't it set git_url back to https://git.torproject.org/pluggable-transports/snowflake.git? It changed in 4ff2be0b02e322716f06829e49c50f39795bf43c.

Commit b4f4b29a037fd2444423835da5999f39525f3d24 actually isn't pushed to https://github.com/cohosh/snowflake yet.

Error: Cannot checkout b4f4b29a037fd2444423835da5999f39525f3d24:
fatal: reference is not a tree: b4f4b29a037fd2444423835da5999f39525f3d24

comment:4 Changed 4 weeks ago by cohosh

Thanks for catching that, I did a make clean without configuring it right and was waiting for a rebuild. Updated the patch.

comment:5 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, this got applied to master (commit 2b8726a176e3f01c44e714f4b56024a912fb6ab2).

Note: See TracTickets for help on using tickets.