Opened 4 weeks ago

Last modified 4 weeks ago

#32072 new defect

Fix Field Name For Tor Binary to Match Orbot

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910
Cc: gk, sysrqb, eighthave Actual Points:
Parent ID: #32069 Points:
Reviewer: Sponsor:

Description

Match up the tor version field names. Note The binary version is currently out of date but we can update this as part of syncing the projects.

Child Tickets

Change History (5)

comment:2 Changed 4 weeks ago by eighthave

For tor-android, I did this too: https://github.com/eighthave/tor-android/commit/6993fce4be07f1dc8e796bb5a3d74a2e0eae90e4 so the AAR package version name is based on the git tag of the included tor.

comment:3 Changed 4 weeks ago by eighthave

Seems like a good solution would be to do this via the BuildConfig class. In build.gradle, its possible to add things to BuildConfig, then its statically available. So there could be some BuildConfig value based on that getVersionName().

comment:4 in reply to:  3 Changed 4 weeks ago by sisbell

I think we likely will be just importing the binaries from somewhere. In the case of tor-browser-build this would come in from the projects/tor dependency. But yes hard-coding in a Java field is not good. I think we can pull that version info from file name or some metadata within the file.

Replying to eighthave:

Seems like a good solution would be to do this via the BuildConfig class. In build.gradle, its possible to add things to BuildConfig, then its statically available. So there could be some BuildConfig value based on that getVersionName().

comment:5 Changed 4 weeks ago by gk

Keywords: ff68-esr removed

Nothing related to ff68-esr transition.

Note: See TracTickets for help on using tickets.