Opened 4 weeks ago

Closed 4 weeks ago

#32076 closed task (fixed)

Update goptlib to v1.1.0

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: goptlib TorBrowserTeam201910R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor Browser currently includes version 0.5. #32056 is caused by a bug that was fixed in goptlib 0.7. Here is a patch to upgrade to the latest v1.1.0.

Here is the diff in goptlib. The most notable change is that it uses SOCKS 5 since version 0.6, not SOCKS 4a.
https://gitweb.torproject.org/pluggable-transports/goptlib.git/diff/?id=v1.1.0&id2=0.5

Child Tickets

Attachments (1)

0001-Bug-32076-Upgrade-to-goptlib-v1.1.0.patch (737 bytes) - added by dcf 4 weeks ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 weeks ago by dcf

I'm doing a testbuild of this patch now. Before starting the testbuild I did a rbm/rbm build goptlib --target alpha --target torbrowser-linux-x86_64 and it compiled without error.

comment:2 in reply to:  1 Changed 4 weeks ago by gk

Replying to dcf:

I'm doing a testbuild of this patch now. Before starting the testbuild I did a rbm/rbm build goptlib --target alpha --target torbrowser-linux-x86_64 and it compiled without error.

FWIW: we'll start an alpha build later this week. Let me know whether we should include the patch in it.

comment:3 Changed 4 weeks ago by dcf

Keywords: TorBrowserTeam201910R added
Status: newneeds_review

The build completed without error (after adding the patch for #32061 too). I was able to bootstrap linux64 with obfs4 with and without a proxy. Running obfs4proxy with a bad proxy string gives the expected PROXY-ERROR, not a panic.

$ TOR_PT_MANAGED_TRANSPORT_VER=1 TOR_PT_CLIENT_TRANSPORTS=obfs4 TOR_PT_STATE_LOCATION=. TOR_PT_PROXY=socks5://127.0.0.1:99999 Browser/TorBrowser/Tor/PluggableTransports/obfs4proxy
VERSION 1
PROXY-ERROR proxy URI has invalid host: not a Port string: "99999"

comment:4 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit d0139c1f9a838732577a38b88dc6d341bed65308).

Note: See TracTickets for help on using tickets.