Opened 4 weeks ago

Last modified 4 weeks ago

#32077 new defect

Remove Compile Time Dependencies Between Tor Service and VPN

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910
Cc: gk, sysrqb, eighthave Actual Points:
Parent ID: #32069 Points:
Reviewer: Sponsor:

Description

Decouple the compile time dependencies of the service module on the vpn module. This makes it easy to remove VPN module from the build if not needed.

Child Tickets

Change History (5)

comment:1 Changed 4 weeks ago by sisbell

Move toward the use of preferences rather than fields, as this decouples the code.

https://github.com/sisbell/tor-android-service/commit/ac0a066c9ee75c0e869f6c95401b8134a2248c25

comment:2 Changed 4 weeks ago by eighthave

Looking at decoupling commits like this makes me think that decoupling work like this should be put on hold, since I'm just about to start making major changes to the tor service aspect of Orbot. The current approach is deprecated, and will only be maintained for security releases. We're going to integrate the new TorService into Orbot, and release the new "Orbot mini" based on that. That will be our first big test of all this.

comment:3 in reply to:  2 Changed 4 weeks ago by sisbell

Replying to eighthave:

Looking at decoupling commits like this makes me think that decoupling work like this should be put on hold, since I'm just about to start making major changes to the tor service aspect of Orbot. The current approach is deprecated, and will only be maintained for security releases. We're going to integrate the new TorService into Orbot, and release the new "Orbot mini" based on that. That will be our first big test of all this.

+1 It makes sense holding off until orbot mini is out. The biggest changes revolved around removing VPN code from service code. The rest of the commits are easy enough to redo when we are ready.

comment:4 Changed 4 weeks ago by eighthave

The VPN stuff is the part that will probably be touched the least, so perhaps it makes sense to merge those changes sooner rather than later.

comment:5 Changed 4 weeks ago by gk

Keywords: ff68-esr removed

Nothing related to ff68-esr transition.

Note: See TracTickets for help on using tickets.