Opened 5 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#32086 closed enhancement (implemented)

Try Visual Studio 2019 image in appveyor

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, consider-backport-immediately, 035-backport, 040-backport, 041-backport, 042-backport
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

We can't afford the build time for 3 images, so we should probably replace 2017.

Child Tickets

Change History (5)

comment:1 Changed 4 weeks ago by teor

Actual Points: 0.1
Keywords: 029-backport 035-backport 040-backport 041-backport 042-backport added
Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final
Status: assignedneeds_review

Here's a test branch on master:
https://github.com/torproject/tor/pull/1431

Here's the Appveyor image reference:
https://www.appveyor.com/docs/windows-images-software/#operating-system

If the branch passes, we should cherry-pick to maint-0.2.9, create test branches for every maint branch, check CI, and then merge.

comment:2 Changed 4 weeks ago by teor

Keywords: consider-backport-immediately added; 029-backport removed
Points: 0.1

Here's the PR for review and merge:

The merge forward is clean, here are the branches:

comment:3 Changed 4 weeks ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

This makes sense! And simple enough.

comment:4 Changed 4 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to 0.3.5 and forward.

comment:5 Changed 4 weeks ago by teor

Milestone: Tor: 0.4.3.x-finalTor: 0.3.5.x-final

Please move backported tickets to the earliest backport milestone.

Note: See TracTickets for help on using tickets.