Opened 5 weeks ago

Closed 4 weeks ago

#32106 closed defect (fixed)

tor man page should clarify that KBytes is 1024 bytes

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: manpage, tor-doc. 042-can, 042-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:

Description (last modified by arma)

We say K as if everybody knows its 210. But it has confused peripheral apps, like apparently nyx looks at "15 GBytes" in a torrc file, and helpfully visualizes 15 billion bytes for the user, when actually Tor means 15 << 30 (a bit over 16 billion bytes) the whole time.

This distinction doesn't matter much in the kbyte range, but in the gbyte range it can add up. And for folks who are trying to do bandwidth accounting properly, it could be a nasty surprise -- especially if their ISP counts gigabytes as billions of bytes.

Child Tickets

Change History (11)

comment:1 Changed 5 weeks ago by weasel

Description: modified (diff)

comment:2 Changed 5 weeks ago by arma

Description: modified (diff)

comment:3 Changed 5 weeks ago by arma

Status: newneeds_review

My bug32106 branch resolved this ticket.

(I snuck in a few other man page fixes, like mentioning that case doesn't matter in units, and no longer making it seem reasonable that you would do any accounting operations with a single gigabyte.)

comment:4 Changed 4 weeks ago by dgoulet

Keywords: manpage tor-doc added
Reviewer: catalyst

comment:5 Changed 4 weeks ago by ahf

Status: needs_reviewneeds_revision

Needs revision for same reason as #32108

comment:6 Changed 4 weeks ago by arma

shiny new github pull request is at https://github.com/torproject/tor/pull/1439

comment:7 Changed 4 weeks ago by nickm

Status: needs_revisionneeds_review

comment:8 Changed 4 weeks ago by teor

Status: needs_reviewmerge_ready

This seems fine, I will merge when CI is happier.

comment:9 Changed 4 weeks ago by teor

Keywords: tor-doc. 042-can added; tor-doc removed
Milestone: Tor: 0.4.3.x-finalTor: 0.4.2.x-final
Reviewer: catalystteor

Documentation changes can go in 0.4.2, I'll cherry-pick and merge forward.

comment:10 Changed 4 weeks ago by teor

Keywords: 042-backport added

comment:11 Changed 4 weeks ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to 0.4.2 and later.
Merged #32106, #31807, #31001, #23818, #12399, and #31372 together.

Note: See TracTickets for help on using tickets.