Opened 4 weeks ago

Closed 9 days ago

#32111 closed defect (fixed)

Adding your own custom bridges generates a parsing error

Reported by: ggus Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910R
Cc: pospeselr, tbb-team Actual Points: 0.5
Parent ID: Points:
Reviewer: Sponsor: Sponsor30

Description

In Tor Browser alpha (9.0a8), if I add a custom bridge starting with Bridge:

Bridge obfs4 IP:Port cert

It gives me a parsing error:

10/16/19, 13:22:41.785 [WARN] Error parsing Bridge address 'obfs4'

But it works if I add directly:"obfs4 IP:Port cert..."

In Tor Browser stable it works both ways (Bridge and only obfs4).

Child Tickets

Change History (7)

comment:1 Changed 4 weeks ago by mcs

The Tor Launcher code (used prior to TB 9.0a8) strips off "bridge", extra whitespace, etc. I guess the new about:preferences code should do something similar.

https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/content/network-settings.js#n2413

comment:2 Changed 4 weeks ago by gk

Cc: pospeselr added
Keywords: TorBrowserTeam201910 added

comment:3 Changed 4 weeks ago by gaba

Sponsor: Sponsor30

comment:4 Changed 4 weeks ago by pospeselr

Cc: tbb-team added
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

Updated the bridge string parse method to handle strings the same as tor-launcher (handling bridge prefix and carriage returns correctly)

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32111_review

comment:5 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to tor-browser-68.1.0esr-9.0-3 (7aca86c1666873378ab6b9845acdee93b16468a9) (I added a fixup commit to deal with some typos (commit 83a889d1fcdc8cb01497faaa225987e22d91d94b))

comment:6 Changed 9 days ago by pospeselr

Actual Points: 0.5
Resolution: fixed
Status: closedreopened

comment:7 Changed 9 days ago by pospeselr

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.