Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#32112 closed defect (fixed)

Escaping & character creates weird string

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-must, TorBrowserTeam201910R
Cc: emmapeel, pospeselr Actual Points: 0.1
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

For #31286 we committed new strings such as

<!ENTITY torPreferences.viewLogs "View Logs&#x2026;">

When pulling the translated strings that suddenly mutated to

<!ENTITY torPreferences.viewLogs "View Logs&amp;#x2026;">

We should figure out a way where the & actually gets preserved because otherwise users are seeing the second string literally.

This bug might be responsible for XML parsing errors too, which I am seeing in the browser console.

Child Tickets

Change History (3)

comment:1 Changed 4 weeks ago by emmapeel

I wonder, if &#x2026; is ellipsis, why we don't use the actual ellipsis … ?

Not sure in the English source, but at least in Spanish the text is utf-8 i think.

The Spanish translation has an ellipsis to test, see:

https://gitweb.torproject.org/translation.git/commit/es/network-settings.dtd?h=tor-launcher-network-settings&id=e7ba8958130cb4190d9d84f4f1e831a227390239

comment:2 Changed 4 weeks ago by gk

Resolution: fixed
Status: newclosed

bug_32112 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_32112&id=53fd49865ef9794a319582ad7cd4b551d8e89051) is the proposed fix. pospeselr ack'ed it on IRC and I merged it to master (commit 53fd49865ef9794a319582ad7cd4b551d8e89051).

comment:3 Changed 4 weeks ago by gk

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Note: See TracTickets for help on using tickets.