Opened 8 weeks ago

Closed 2 days ago

Last modified 43 hours ago

#32116 closed defect (fixed)

Fix tor-browser's .mozconfig so that ./mach configure succeeds on Linux by default

Reported by: pospeselr Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201912R
Cc: tbb-team, pili Actual Points: 0.5
Parent ID: Points: 0
Reviewer: gk Sponsor:

Description

Currently --enable-tor-browser-update needs to be removed and --with-tor-browser-version=FOO need to be added to the .mozconfig for the tor-browser project to build. The tor-browser-build build system uses its own per-platform mozconfig when building tor-browser releases, so updating the one in tor-browser will not affect official builds.

Child Tickets

Change History (16)

comment:1 Changed 8 weeks ago by pospeselr

Cc: tbb-team added
Keywords: TorBrowserTeam201910R added
Points: 0
Status: assignedneeds_review

Added --with-tor-browser-version=dev-build and commented out --enable-tor-browser-update

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32116

comment:2 Changed 8 weeks ago by pospeselr

Actual Points: 0

comment:3 Changed 8 weeks ago by gk

Hm, I guess we should come up with a general idea of what the purpose of the .mozconfig files in tor-browser is and then treat all of them accordingly. Maybe my idea of just being able to build tor-browser out of the box with proper settings should be reconsidered, dunno.

comment:4 Changed 5 weeks ago by pili

Keywords: TorBrowserTeam201911 added

Moving tickets to November 2019

comment:5 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201910R removed

There is no way to do reviews in October 2019 anymore.

comment:6 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201911 removed

No need for duplicate keyword.

comment:7 Changed 10 days ago by gk

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201911R removed

We are in December now.

comment:8 Changed 10 days ago by pospeselr

Updated patch to include comment at the top pointing developers to the official mozconfigs in tor-browser-build.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32116_v2

comment:9 in reply to:  8 Changed 9 days ago by gk

Status: needs_reviewneeds_information

Replying to pospeselr:

Updated patch to include comment at the top pointing developers to the official mozconfigs in tor-browser-build.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32116_v2

This looks okay to me. However, even with those changes the configure step does not succeed by default due to Tor Launcher missing. So, I guess the patch does not deliver what the ticket wants?

comment:10 Changed 8 days ago by gk

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201912R removed

Taking this off of our review radar as we are in needs_information.

comment:11 Changed 8 days ago by pospeselr

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201912 removed
Status: needs_informationneeds_review

So, I'm coming at this primarily using the tor-browser repo to do incremental 64-bit Linux desktop builds. I don't think I've ever had a dev scenario where I didn't clone the tor-launcher repo.

What does the Tor Browser Android devs workflow look like? Do y'all use the tor-browser repo for Android builds, or do you to use tor-browser-build?

Pushed a fixup commit that adds --disable-tor-launcher here:

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32116_v2

Either way, only having to comment out --disable-tor-launcher in the mozconfig will make desktop devs lives easier.

comment:12 in reply to:  11 Changed 7 days ago by sysrqb

Replying to pospeselr:

So, I'm coming at this primarily using the tor-browser repo to do incremental 64-bit Linux desktop builds. I don't think I've ever had a dev scenario where I didn't clone the tor-launcher repo.

What does the Tor Browser Android devs workflow look like? Do y'all use the tor-browser repo for Android builds, or do you to use tor-browser-build?

I use both, but I use tor-browser for faster development with incremental builds. tor-launcher isn't included on Android, so we don't run into that problem.

comment:13 Changed 6 days ago by gk

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201912R removed
Reviewer: gk
Status: needs_reviewneeds_revision

Looks good to me. Could you just squash both commits and then make *that* result a fixup commit to the mozconfig one we have on each branch? So, for tor-browser-68.3.0esr-9.5-1 this would be commit 92f76f10b3ea621c8b1f8ede0837d28ea0e460dc.

comment:14 Changed 3 days ago by pospeselr

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201912 removed
Status: needs_revisionneeds_review

Ok, squashed the two commits, made them a fixup to 92f76f10b3ea621c8b1f8ede0837d28ea0e460dc, and force pushed them to bug_32116_v2

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32116_v2&id=cb3038cf717f25e759fb3fdc0a8e941dbfc4e0f1

comment:15 Changed 2 days ago by gk

Cc: pili added
Resolution: fixed
Status: needs_reviewclosed

Looks good now, thanks. Merged to tor-browser-68.3.0esr-9.5-1 (commit cb3038cf717f25e759fb3fdc0a8e941dbfc4e0f1).

FWIW: I don't think this did cost you 0 points, meaning no time, but that's a thing Pili needs to decide/raise. :)

comment:16 Changed 43 hours ago by pospeselr

Actual Points: 00.5
Note: See TracTickets for help on using tickets.