Opened 4 weeks ago

Last modified 5 days ago

#32138 new defect

Clicking the 'new Identity' button in full screen on macOS causes the top and bottom of the browser to show white bars that do not go away

Reported by: Dbryrtfbcbhgf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-issues, tbb-parity, TorBrowserTeam201912
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Full-screening TorBrowser then clicking the 'new Identity' button causes tor browser to come out of full screen and the top and bottom of the browser have large white bars.

  1. Open TorBrowser 9.0a8 on macOS 10.15 and click the green full screen button.
  2. Click the 'new Identity' button and choose to have a new Identity. Image attached showing the white bars.

Child Tickets

Attachments (1)

Screen Shot 2019-10-17 at 9.46.28 PM.png (613.0 KB) - added by Dbryrtfbcbhgf 4 weeks ago.

Download all attachments as: .zip

Change History (8)

Changed 4 weeks ago by Dbryrtfbcbhgf

comment:1 Changed 4 weeks ago by Thorin

The white bars are letterboxing, that's normal. It's stepping your width in 200's and height in 100's to allow for the maximum real estate used in the inner window. In your attachment, your inner window is approx 1334 pixels, but your viewport height is only 1200 - so that's a little weird: I would have expected it to be 1300.

When you first went to FS, did the inner window not get letterboxed?

FWIW: on windows 7, if I enter FS, I get letterboxed. When I mouse up to show the chrome and click new Identity, I get a new 1000x1000px window

comment:2 in reply to:  1 Changed 4 weeks ago by Dbryrtfbcbhgf

Replying to Thorin:

The white bars are letterboxing, that's normal. It's stepping your width in 200's and height in 100's to allow for the maximum real estate used in the inner window. In your attachment, your inner window is approx 1334 pixels, but your viewport height is only 1200 - so that's a little weird: I would have expected it to be 1300.

When you first went to FS, did the inner window not get letterboxed?

FWIW: on windows 7, if I enter FS, I get letterboxed. When I mouse up to show the chrome and click new Identity, I get a new 1000x1000px window

When TorBrowser is brought out of full screen the letterboxing should not be visible, bringing Torbrowser out of full screen by clicking the green minimize button, Does Not show the letterboxing white bars, they only appear when clicking the new Identity button in full screen.
I made a video showing the bug occur. https://streamable.com/tveai

Last edited 4 weeks ago by Dbryrtfbcbhgf (previous) (diff)

comment:3 Changed 4 weeks ago by Thorin

Thanks for the vid

I'm not mac savvy at all, so correct me if I'm wrong. But to me it looks like letterboxing it's working as it's meant to, except I don't fully understand the mac actions (and the video is too fast for an old guy like me). OK, I downloaded the vid and am playing it locally at super slow speed :) I'm typping comments as I go, so it might get a little messy

Some comments

  • That doesn't look like FS (full screen) to me (the urlbar is still visible), that looks like maximizing. However, letterboxing doesn't distinguish those, and should work the same way.
  • When you open TB and the size is perfect (no letterboxing), e.g 1000x1000 and you go FS and then non-FS (i.e you return to the original state), or go maximized and then restore: well, of course the restored state will not have letterboxing, because it didn't before you maximized/FS'ed it.

This is what I see:

  • 12 secs: you start tor, etc
  • 15 secs: it has loaded chrome but no content (pale grey)
  • 16 secs: it has loaded the Tor Browser purple text in the urlbar
  • 17 secs: it has loaded the content (the purple page). It is not letterboxed (therefore it is in multiples of 200x100 or see note below), and the size has not changed from first paint
  • 18/19 seconds - you have clicked the green button, and it transitions to a maximized state and letterboxing kicks in (it doesn't look vertically centered)
  • 21 seconds - you have clicked the green button again, and it restores and the letterboxing has gone. It is back at the same size. I took screen shots of each stage and compared them
  • Note: sometimes, letterboxing does not kick in on the very first page load: I have not seen this in TB, but I get it every time on my Firefox. My landing/home page of speed dials loads before letterboxing. It's a speed/racy thing. I can't tell if this is the case in your vid.

So at this stage, that part is working fine AFAICT

---

The first part of the video

  • 0 secs: TB is open, no letterboxing
  • 1 secs: you click the green button, it maximizes, gets letterboxed
  • 2 secs: you click new ID
  • 3 secs: the existing window is closed
  • 4 secs: a new window opens, but the size is full height (it wasn't when you started TB at the 12+ sec mark)
  • 5 secs: the purple tor page is loaded and letterboxing has kicked it, as it should because the inner window height is not what it should be, it is trying to use full height

When you go new ID, all exiting windows are destroyed and you get a brand new one which does not respect any previous window sizes or states

It might help is you grabbed the inner window screen measurements at each step: e.g load https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html - but I don't think that there is a problem with that.

The problem seems to be that, on Mac, the new window height is not adjusted

comment:4 Changed 3 weeks ago by Dbryrtfbcbhgf

Load window size: 1000 x 600
Full screen: 1200 x 700
After I click the new Identity button: 100 x 600 , The total browser window is larger here to compensate for the letterboxing cutting off the top and bottom of the visible web content.

comment:5 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issues added

comment:6 Changed 6 days ago by gk

Keywords: tbb-parity added
Summary: Clicking the 'new Identity' button in full screen causes the top and bottom of the browser to show white bars that do not go awayClicking the 'new Identity' button in full screen on macOS causes the top and bottom of the browser to show white bars that do not go away

FWIW: this is a macOS-only issue it seems.

comment:7 Changed 5 days ago by sysrqb

Keywords: TorBrowserTeam201912 added
Note: See TracTickets for help on using tickets.