Stop using HAVE_MODULE_{DIRAUTH,RELAY} inside functions

In doc/HACKING/Modules.md, we say that we don't use module macros inside functions. But HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY are used inside a few functions.

We should stop using HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY inside functions, or update the documentation to say "avoid using".

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #31851 (moved)

added actualpoints::0.1 component::core tor/tor milestone::Tor: 0.4.3.x-final network-team-roadmap-november owner::teor parent::31851 points::0.1 priority::medium resolution::fixed reviewer::nickm severity::normal sponsor::31-can status::closed type::enhancement labels

#32213 (moved) removes the config.c HAVE_MODULE_DIRAUTH in functions.

The remaining uses are:

• routerlist.c
• subsystem_list.c

#32162 (moved) will remove the HAVE_MODULE_RELAY in functions.

Trac:
Description: In doc/HACKING/Modules.md, we say that we don't use module macros inside functions. But HAVE_MODULE_DIRAUTH is used inside a few functions.

We should stop using HAVE_MODULE_DIRAUTH inside functions, or update the documentation to say "avoid using".

to

In doc/HACKING/Modules.md, we say that we don't use module macros inside functions. But HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY are used inside a few functions.

We should stop using HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY inside functions, or update the documentation to say "avoid using".
Summary: Stop using HAVE_MODULE_DIRAUTH inside functions to Stop using HAVE_MODULE_{DIRAUTH,RELAY} inside functions

See my PR:

• master: https://github.com/torproject/tor/pull/1533

#32162 (moved) will remove the HAVE_MODULE_RELAY in router.c, by making the whole file relay-only. (And it's actually outside a function.)

Trac:
Status: new to needs_review
Actualpoints: N/A to 0.1
Keywords: network-team-roadmap-october, tor-design deleted, network-team-roadmap-november added
Points: N/A to 0.1
Reviewer: N/A to nickm
Type: defect to enhancement

Short and simple. LGTM.

Trac:
Status: needs_review to merge_ready

Trac:
Owner: N/A to teor
Status: merge_ready to assigned

Merged to master.

Trac:
Status: assigned to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #31851 (moved)

moved to tpo/core/tor#32163 (closed)