"View the Tor logs" puts an extra space at the end of each log line

I'm using the new Tor Browser 9.0 build2 on Linux 64-bit.

When I go to edit->preferences->Tor and go to the bottom and click "View Logs..." I get to see the Tor logs. Cool!

But there's a minor weirdness: every line has an extra space at the end.

added TorBrowserTeam201910R actualpoints::0.1 component::applications/tor browser owner::pospeselr points::0.1 priority::low resolution::fixed severity::normal status::closed tbb-9.0-issues tbb-9.0.1-can type::defect labels

Trac:
Keywords: N/A deleted, tbb-9.0-issues, tbb-9.0.1-can added

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Trac:
Cc: N/A to tbb-team

The log message we receive from tor all seem to have a trailing space. This patch trims() the message before appendnig it to the log.

tor-launcher: https://gitweb.torproject.org/user/richard/tor-launcher.git/commit/?h=bug_32164

Trac:
Keywords: N/A deleted, TorBrowserTeam201910R added
Status: assigned to needs_review

Replying to pospeselr:

The log message we receive from tor all seem to have a trailing space.

Gosh. That shouldn't be happening. We should put a bit of energy into learning why it happens, rather than just trimming it and leaving the weirdness in place.

Option one, Tor is somehow including a trailing space in its log events. If so, we should stop. Option two, Tor Launcher is somehow adding a trailing space when it receives the log events.

Does Tor Launcher see trailing spaces on events of other kinds?

I am cc'ing atagar since he either dealt with this in stem, or has no idea what we're talking about.

Trac:
Cc: tbb-team to tbb-team, atagar

Ok, it looks like Tor is adding the trailing whitespace.

So, yes, please trim it on the Tor Browser side, and I will open a ticket for Tor to stop doing it.

Replying to arma:

I will open a ticket for Tor to stop doing it.

Ok this Tor bug is #32178 (moved).

Fixed with commit dd8147ceed102f93f246e67c91dcc36139451c8b on master. Please base your branch the next time on the master branch. I can then just merge without the need for some cherry-picking.

Trac:
Points: N/A to 0.1
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Status: closed to reopened
Actualpoints: N/A to 0.1
Resolution: fixed to N/A

I guess you meant to close that again... ;)

Trac:
Status: reopened to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #32178 (moved)

mentioned in issue tpo/core/tor#32178 (closed)

moved to tpo/applications/tor-browser#32164 (closed)