Opened 3 weeks ago

Closed 8 days ago

#32164 closed defect (fixed)

"View the Tor logs" puts an extra space at the end of each log line

Reported by: arma Owned by: pospeselr
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-issues, tbb-9.0.1-can, TorBrowserTeam201910R
Cc: tbb-team, atagar Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

I'm using the new Tor Browser 9.0 build2 on Linux 64-bit.

When I go to edit->preferences->Tor and go to the bottom and click "View Logs..." I get to see the Tor logs. Cool!

But there's a minor weirdness: every line has an extra space at the end.

Child Tickets

Change History (10)

comment:1 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issues tbb-9.0.1-can added

comment:2 Changed 3 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:3 Changed 3 weeks ago by boklm

Cc: tbb-team added

comment:4 Changed 3 weeks ago by pospeselr

Keywords: TorBrowserTeam201910R added
Status: assignedneeds_review

The log message we receive from tor all seem to have a trailing space. This patch trims() the message before appendnig it to the log.

tor-launcher: https://gitweb.torproject.org/user/richard/tor-launcher.git/commit/?h=bug_32164

comment:5 in reply to:  4 Changed 3 weeks ago by arma

Cc: atagar added

Replying to pospeselr:

The log message we receive from tor all seem to have a trailing space.

Gosh. That shouldn't be happening. We should put a bit of energy into learning why it happens, rather than just trimming it and leaving the weirdness in place.

Option one, Tor is somehow including a trailing space in its log events. If so, we should stop. Option two, Tor Launcher is somehow adding a trailing space when it receives the log events.

Does Tor Launcher see trailing spaces on events of other kinds?

I am cc'ing atagar since he either dealt with this in stem, or has no idea what we're talking about.

comment:6 Changed 3 weeks ago by arma

Ok, it looks like Tor is adding the trailing whitespace.

So, yes, please trim it on the Tor Browser side, and I will open a ticket for Tor to stop doing it.

comment:7 in reply to:  6 Changed 3 weeks ago by arma

Replying to arma:

I will open a ticket for Tor to stop doing it.

Ok this Tor bug is #32178.

comment:8 Changed 3 weeks ago by gk

Points: 0.1
Resolution: fixed
Status: needs_reviewclosed

Fixed with commit dd8147ceed102f93f246e67c91dcc36139451c8b on master. Please base your branch the next time on the master branch. I can then just merge without the need for some cherry-picking.

comment:9 Changed 9 days ago by pospeselr

Actual Points: 0.1
Resolution: fixed
Status: closedreopened

comment:10 Changed 8 days ago by gk

Resolution: fixed
Status: reopenedclosed

I guess you meant to close that again... ;)

Note: See TracTickets for help on using tickets.