Opened 3 weeks ago

Closed 3 weeks ago

#32169 closed defect (fixed)

TB9: Wikipedia address bar search broken

Reported by: rustybird Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-9.0-issues, tbb-9.0.1-can, tbb-regression, TorBrowserTeam201910R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Using the TB9 address bar to search for anything on Wikipedia, the browser just makes a GET request to https://en.wikipedia.org/wiki/Special:Search without any parameters.

Tested with https://people.torproject.org/~gk/builds/9.0-build2/tor-browser-linux64-9.0_en-US.tar.xz

Child Tickets

Attachments (1)

Bug-32169-Fix-TB9-Wikipedia-address-bar-search.patch (1.4 KB) - added by rustybird 3 weeks ago.
v2

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 weeks ago by rustybird

I notice that wikipedia/manifest.json is the only enabled search provider that neither specifies a search_url_get_params/search_url_post_params, nor hardcodes the params in the search_url. (They are hardcoded in search_form. I guess Firefox does not use this anymore?)

Working on a patch...

comment:2 Changed 3 weeks ago by rustybird

Okay, here's the one-liner patch. [Edit: Replaced by a prettier v2 that also includes an explanation.] I verified that it works by rezipping the updated Wikipedia manifest.json into tor-browser_en-US/Browser/browser/omni.ja.

Last edited 3 weeks ago by rustybird (previous) (diff)

Changed 3 weeks ago by rustybird

v2

comment:3 Changed 3 weeks ago by arma

Status: newneeds_review

comment:4 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issue tbb-9.0.1-can tbb-regression TorBrowserTeam201910R added

comment:5 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issues added; tbb-9.0-issue removed

comment:6 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for the patch. I cherry-picked it (with slightly adapted commit message) to tor-browser-68.2.0esr-9.5-1 (commit 9c6f36175099ac18740064b39aca1a3eb596741a) and tor-browser-68.2.0esr-9.0-1 (commit d9bdd00cdd884f0c854affe0d0f13ce709ee75fb).

Note: See TracTickets for help on using tickets.