Opened 12 months ago

Closed 5 months ago

Last modified 5 months ago

#32174 closed defect (fixed)

replace XUL <textbox> with <html:input>

Reported by: mcs Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ff78-esr, BugSmashFund, TorBrowserTeam202006R, ReleaseTrainMigration
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Mozilla has removed XUL <textbox>, although only partially in the ESR68 timeframe (see #32154 where we had to replace a multiline usage with <html:textarea>). We need to finish the job and replace our remaining uses of <textbox> with <html:input>.

While we are at it, we should double check that we do not use <textbox> outside of Tor Launcher, either in the Torbutton code or in a Firefox patch.

Child Tickets

Change History (7)

comment:1 Changed 11 months ago by mcs

Keywords: BugSmashFund added

comment:2 Changed 7 months ago by acat

Keywords: TorBrowserTeam202004R added
Status: newneeds_review

tor-launcher patch: ​https://github.com/acatarineu/tor-launcher/commit/f85556836b5cbda80e1f9bc5fff49da0e7d5a980

For Tor Browser patches, this is already done in #33533, so perhaps this can be reviewed there.

comment:3 Changed 6 months ago by acat

Keywords: ReleaseTrainMigration added
Sponsor: Sponsor58-can

comment:4 Changed 6 months ago by mcs

Status: needs_reviewmerge_ready

r=brade, r=mcs
Looks good.

comment:5 Changed 5 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202004R removed

comment:6 Changed 5 months ago by gk

Resolution: fixed
Status: merge_readyclosed

This landed on master (commit 32603f686e3d006d60633a52d0cf9f6cd6cdc2ef), thanks.

Last edited 5 months ago by gk (previous) (diff)

comment:7 Changed 5 months ago by gk

Sponsor: Sponsor58-can
Note: See TracTickets for help on using tickets.