Opened 4 months ago

Closed 4 months ago

#32175 closed defect (fixed)

test_options.c uses some very wonky options objects.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: nickm, teor Actual Points: .2
Parent ID: #31241 Points:
Reviewer: teor Sponsor: Sponsor31-can

Description

In test_options, see this unfortunate comment:

  // XXX: Really, all of these options should be set to defaults
  // with options_init(), but about a dozen tests break when I do that.

This is something we need to fix to make the options tests reasonable.

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by nickm

Actual Points: .2

Branch is bug32175 with PR at https://github.com/torproject/tor/pull/1438 .

It makes test_options.c a few hundred lines shorter. Will needs_review once CI passes.

comment:2 Changed 4 months ago by teor

CI seems slow, I opened #32177.

comment:3 Changed 4 months ago by nickm

Reviewer: teor
Status: assignedneeds_review

Yeah, it's still waiting. Are you okay reviewing this one, teor? Tentatively putting you on it. Once this and #31999 are in, I can make more progress on options_validate cleanup.

comment:4 Changed 4 months ago by teor

Reviewer: teor
Status: needs_reviewmerge_ready

Looks great, I am so happy we are finally cleaning up these tests.

Some of the mass replaces would have been better as scripts, but they all look fine.

Ready for merge, as soon as CI passes.

comment:5 Changed 4 months ago by teor

Reviewer: teor

comment:6 Changed 4 months ago by teor

CI has passed.

comment:7 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master!

Note: See TracTickets for help on using tickets.