test_options.c uses some very wonky options objects.

In test_options, see this unfortunate comment:

  // XXX: Really, all of these options should be set to defaults
  // with options_init(), but about a dozen tests break when I do that.

This is something we need to fix to make the options tests reasonable.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #31241 (moved)

added actualpoints::.2 component::core tor/tor milestone::Tor: 0.4.3.x-final owner::nickm parent::31241 priority::medium resolution::fixed reviewer::teor severity::normal sponsor::31-can status::closed type::defect labels

Branch is bug32175 with PR at https://github.com/torproject/tor/pull/1438 .

It makes test_options.c a few hundred lines shorter. Will needs_review once CI passes.

Trac:
Actualpoints: N/A to .2

CI seems slow, I opened #32177 (moved).

Yeah, it's still waiting. Are you okay reviewing this one, teor? Tentatively putting you on it. Once this and #31999 (moved) are in, I can make more progress on options_validate cleanup.

Trac:
Reviewer: N/A to teor
Status: assigned to needs_review

Looks great, I am so happy we are finally cleaning up these tests.

Some of the mass replaces would have been better as scripts, but they all look fine.

Ready for merge, as soon as CI passes.

Trac:
Status: needs_review to merge_ready
Reviewer: teor to N/A

Trac:
Reviewer: N/A to teor

CI has passed.

Merged to master!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

added 1h 36m of time spent

mentioned in issue #32185 (moved)

mentioned in issue #31241 (moved)

moved to tpo/core/tor#32175 (closed)

mentioned in issue tpo/core/tor#32185 (closed)