Opened 3 weeks ago

Closed 3 weeks ago

Last modified 9 days ago

#32184 closed defect (fixed)

Update from esr68-based Tor Browser to a new esr68-based Tor Browser shows red dot while downloading

Reported by: gk Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-issues, tbb-regression, tbb-9.0.1-can, TorBrowserTeam201910R, tbb-update
Cc: tbb-team Actual Points: 0.25
Parent ID: Points:
Reviewer: Sponsor:

Description

Contrary to what we see with updating a stable version, if I update an alpha release based on esr68 to our latest alpha release (assuming I am actually using an older version in the first place, like 9.0a7) then the process of downloading the update is accompanied with a red dot on the hamburger menu which seems unnecessarily scary, compared to the green arrow we show in the stable series.

Looking closer at what is happening by opening the hamburger menu during that process indicates that maybe an icon is actually missing here as there is no red dot shown in the menu itself, just no icon at all after the message that the update gets downloaded. Once that is done the green arrow icon shows up for a restart, both on the hamburger menu as within it, as we can see with our esr60-based stable updates.

That's visible on different Linux systems at least.

Child Tickets

Change History (6)

comment:1 Changed 3 weeks ago by mcs

Cc: tbb-team added; mcs brade removed
Owner: changed from tbb-team to brade
Status: newassigned

comment:2 Changed 3 weeks ago by mcs

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

When we rebased the #28885 patch, we overlooked a few new rules withing the CSS files and that caused the wrong color/missing icon problem. Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug32184-01&id=03e81dff562d9eda9c056066a50089fdee325dd9

comment:3 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cerry-picked to tor-browser-68.2.0esr-9.5-1 (commit c5ef11aaa653334882a48a79c403c063500a129a) and merged to tor-browser-68.2.0esr-9.0-1 (commit 03e81dff562d9eda9c056066a50089fdee325dd9).

I guess that means users will see the problem from 9.0 -> 9.0.1 but it's not the end of the world.

comment:4 in reply to:  3 Changed 3 weeks ago by mcs

Replying to gk:

I guess that means users will see the problem from 9.0 -> 9.0.1 but it's not the end of the world.

Yes. If more people start to notice this, we could add something to the release notes/blog.

comment:5 Changed 9 days ago by mcs

Points: 0.25

comment:6 Changed 9 days ago by mcs

Actual Points: 0.25
Points: 0.25
Note: See TracTickets for help on using tickets.