Opened 3 months ago

Closed 3 months ago

#32185 closed defect (fixed)

Remove need for options_validate to use "defaults".

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-august
Cc: nickm, teor Actual Points: .1
Parent ID: #31241 Points: .1
Reviewer: Sponsor: Sponsor31-can

Description

The options_validate() function takes a "defaults" argument; it doesn't need to.

Now that #32175 is in, this should be much simpler than the last time I tried to do this.

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by nickm

https://github.com/torproject/tor/pull/1446 is the PR here. Once this is in I can start simplifying and refactoring validation at last.

I'll put this into needs_review after CI has passed.

comment:2 Changed 3 months ago by nickm

Status: assignedneeds_review

Travis has passed; waiting for appveyor.

comment:3 Changed 3 months ago by nickm

Actual Points: .1

comment:4 Changed 3 months ago by nickm

(Note: I'm going to actually remove these arguments in #32187)

comment:5 Changed 3 months ago by ahf

Status: needs_reviewmerge_ready

The patch looks good, but appveyor isn't ready yet. I'm putting this to merge_ready under the condition that appveyor goes green before it gets merged :-)

comment:6 Changed 3 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Appveyor passed; merged this to master.

Note: See TracTickets for help on using tickets.