Opened 3 weeks ago

Closed 9 days ago

#32188 closed defect (fixed)

Missing string in TorStrings.jsm is showing an error in browser console

Reported by: acat Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-issues tbb-9.0.1-can, TorBrowserTeam201910R
Cc: pospeselr, ux-team Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

I think the only missing string is torPreferences.useProxy.

Child Tickets

Change History (7)

comment:1 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201910 added
Points: 0.1

comment:2 Changed 3 weeks ago by gk

Cc: pospeselr added

comment:3 Changed 3 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:4 Changed 3 weeks ago by pospeselr

Cc: ux-team added
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

Two possible fixes here, we can change Tor Browser to use the existing 'I usea proxy to connect to the Internet' tor-launcher string, or we can updated tor-launcher to add the new 'Use a proxy' string.

Pick one or the other, but not both.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32188
tor-launcher: https://gitweb.torproject.org/user/richard/tor-launcher.git/commit/?h=bug_32188

Last edited 3 weeks ago by pospeselr (previous) (diff)

comment:5 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

I think it's worth reusing the string people might recognize from dealing with the Tor Launcher dialog. Thus, I picked the tor-browser option: commit 94f2e5e7e73c3b5b52055eadd0e2dcc864d598c4 on tor-browser-68.2.0esr-9.0-1 and commit cbf86255ae7cfe82b555931d9db3b9e528036c65 on tor-browser-68.2.0esr-9.5-1.

comment:6 Changed 9 days ago by pospeselr

Actual Points: 0.1
Resolution: fixed
Status: closedreopened

comment:7 Changed 9 days ago by pospeselr

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.