Opened 12 months ago

Last modified 9 months ago

#32195 new defect

Rename net_is_disabled, net_is_completely_disabled, and PERIODIC_EVENT_FLAG_NEED_NET

Reported by: nickm Owned by:
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, 043-deferred
Cc: arma, dgoulet Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The net_is_disabled() function returns true when we are in soft hibernation, which can be confusing, and which is probably a partial cause of #32108. Similarly, PERIODIC_EVENT_FLAG_NEED_NET prevents a callback from running when we are in soft hibernation, which is also potentially confusing.

Let's figure out good names for these functions and flags, and audit their usage to make sure that there are no more bugs kicking around.

Child Tickets

TicketStatusOwnerSummaryComponent
#17543closedBring some clarity to behavior of net_is_disabled() vs DisableNetwork vs we_are_hibernating()Core Tor/Tor

Change History (3)

comment:1 Changed 12 months ago by teor

#17543 is an outdated version of this ticket.

It also mentions DisableNetwork and we_are_hibernating().

comment:2 Changed 9 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:3 Changed 9 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: unspecified
Note: See TracTickets for help on using tickets.