Opened 3 months ago

Closed 3 months ago

#32196 closed defect (implemented)

cmux: Implement unit tests

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-cmux, tor-test, BugSmashFund
Cc: Actual Points: 1.5
Parent ID: #29698 Points: 2
Reviewer: nickm Sponsor:

Description

Bottom line is that we have code coverage for the cmux/ewma code but no unit tests actually testing validity/correctness.

This ticket it to implement tests as much as we can.

#29698 is the first addition in a long time to the cmux/ewma subsystem and we have *no* infrastructure whatsoever to test it. We can't merge it until we have proper testing. Thus, putting this ticket as a child.

Child Tickets

Change History (4)

comment:1 Changed 3 months ago by dgoulet

Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

comment:2 Changed 3 months ago by dgoulet

Actual Points: 1.5
Status: assignedneeds_review

NOTE: The EWMA scaling validation is not tested in this branch. This would require way more time and effort. This is the best I can do with the time I have for now.

PR: https://github.com/torproject/tor/pull/1480
Branch: ticket32196_043_01

comment:3 Changed 3 months ago by nickm

Reviewer: nickm

comment:4 Changed 3 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

LGTM; merged to master.

Note: See TracTickets for help on using tickets.