#32203 closed defect (fixed)

BridgeDB doesn't create metrics for vanilla bridges

Reported by: phw Owned by: phw
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords: s30-o21a1
Cc: phw Actual Points: 0.3
Parent ID: #31274 Points: 0.25
Reviewer: cohosh Sponsor: Sponsor30-must

Description

The metrics.py module uses code like the following to weed out invalid transport protocols. Unfortunately, this is also weeding out "vanilla", which results in BridgeDB not counting vanilla bridges:

if not isTransportSupported(bridgeType):                                                                                       
    logging.warning("User requested unsupported transport type %s "     
                    "over HTTPS." % bridgeType)                         
    return

Child Tickets

Change History (5)

comment:1 Changed 12 months ago by phw

Reviewer: cohosh
Status: assignedneeds_review

I have a patch in my fix/32203 branch.

comment:2 Changed 12 months ago by cohosh

Status: needs_reviewneeds_information

This looks good but I left a question on the branch about putting "vanilla" in the list of supported bridge types.

comment:3 Changed 12 months ago by phw

Status: needs_informationneeds_review

Thanks! I responded to your comments here and here, and I added a clarifying comment to the source code. Alternatively, we could also rename SUPPORTED_TRANSPORTS to SUPPORTED_BRIDGE_TYPES in metrics.py, and modify setSupportedTransports().

comment:4 Changed 12 months ago by cohosh

Status: needs_reviewmerge_ready

Okay, this looks good to me.

comment:5 Changed 12 months ago by phw

Actual Points: 0.3
Resolution: fixed
Status: merge_readyclosed

Merged in 049a9d9.

Note: See TracTickets for help on using tickets.