Opened 8 months ago

Closed 6 months ago

#32207 closed task (implemented)

write description of pub-sub architecture

Reported by: catalyst Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-september, s31-docs
Cc: teor, nickm Actual Points: .2
Parent ID: #29215 Points:
Reviewer: catalyst Sponsor: Sponsor31-must

Description


Child Tickets

Change History (7)

comment:1 Changed 8 months ago by catalyst

Sponsor: Sponsor31-canSponsor31-must

comment:2 Changed 7 months ago by gaba

Owner: set to nickm
Status: newassigned

comment:3 Changed 7 months ago by catalyst

Type: defecttask

these are tasks not defects

comment:4 Changed 7 months ago by nickm

Actual Points: .2
Status: assignedneeds_review

I have a first draft. See branch ticket32207 with PR at https://github.com/torproject/tor/pull/1547

comment:5 Changed 7 months ago by asn

Reviewer: catalyst

comment:6 in reply to:  4 Changed 7 months ago by catalyst

Status: needs_reviewneeds_revision

Replying to nickm:

I have a first draft. See branch ticket32207 with PR at https://github.com/torproject/tor/pull/1547

Thanks! Overall, it looks good. I made a minor comment on the pull request. Feel free to merge once you've addressed it.

It could probably use more improvement but I'm lacking concrete suggestions for doing so. Maybe next time I have to write or modify code that touches it, I'll think of some.

comment:7 Changed 6 months ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Fixed up and merged to master!

Note: See TracTickets for help on using tickets.