Opened 3 weeks ago

Closed 3 weeks ago

#32210 closed defect (fixed)

Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set

Reported by: cypherpunks Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-9.0-issues, tbb-9.0.1-can, TorBrowserTeam201910R
Cc: tbb-team Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

In Tor Browser 9.0, there is now a "Tor" section in the preferences. When setting the TOR_SKIP_LAUNCH=1 variable to disable Tor (e.g. if in a transparent proxy environment) then the section is still visible on the left but clicking on it does nothing. It should be hidden when this variable is set to prevent confusion.

Child Tickets

Change History (14)

comment:1 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issues tbb-9.0.1-can added

comment:2 Changed 3 weeks ago by cypherpunks

Someone help I cannnot read any website!

extensions.torbutton.use_nontor_proxy true not workingggggggggggggg

comment:3 Changed 3 weeks ago by cypherpunks

Someone help I cannnot read any website!

extensions.torbutton.use_nontor_proxy true not workingggggggggggggg

I don't see how this is at all relevant to this ticket.

comment:4 Changed 3 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:5 Changed 3 weeks ago by boklm

Cc: tbb-team added

comment:6 Changed 3 weeks ago by pospeselr

Cc: tbb-team removed
Keywords: TorBrowserTeam201910R added
Status: assignedneeds_review

Small patch to hide/disable the tor page in about:preferences when tor-launcher does not own the tor daemon (ie when using system tor)

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32210

comment:7 Changed 3 weeks ago by pospeselr

Cc: tbb-team added

comment:8 Changed 3 weeks ago by cypherpunks

Just add a checkbox or about:config to completely disable Tor and allow user to use their own proxy configuration(socks/http/pac) like in 8.5.

I had to downgrade TB9 to TB8.5.

comment:9 Changed 3 weeks ago by cypherpunks

Just add a checkbox or about:config to completely disable Tor and allow user to use their own proxy configuration(socks/http/pac) like in 8.5.

The TOR_SKIP_LAUNCH=1 variable does that. This is also irrelevant to this ticket.

comment:10 Changed 3 weeks ago by cypherpunks

The TOR_SKIP_LAUNCH=1 variable does that.

How exactly?

comment:12 in reply to:  6 Changed 3 weeks ago by gk

Points: 0.2
Resolution: fixed
Status: needs_reviewclosed

Replying to pospeselr:

Small patch to hide/disable the tor page in about:preferences when tor-launcher does not own the tor daemon (ie when using system tor)

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32210

That's a bit of new code added to different places and I would be hesitating just shipping it in 9.0.1. But it seems it's mainly the mechanism used to hide Sync if it is disabled. Thus, this seems already tested quite a bit. So, this looks good to me and works for me, thanks!

I put your code into proper fixup commits, though, this time. Please do it the next time, too (if there is anything that's worth a fixup commit and not a "real" one).

Applied to tor-browser-68.2.0esr-9.5-1 (commit 5d24d4b6873de2da8afa7cba448905522311a4b8) and tor-browser-68.2.0esr-9.0-1 (commit a339c6ec84d612d37eb409eca1b36706a89c9486).

Please add your points.

comment:13 Changed 3 weeks ago by pospeselr

Actual Points: 0.2
Resolution: fixed
Status: closedreopened

comment:14 Changed 3 weeks ago by pospeselr

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.