Hide the "Tor" section in preferences when TOR_SKIP_LAUNCH=1 is set

In Tor Browser 9.0, there is now a "Tor" section in the preferences. When setting the TOR_SKIP_LAUNCH=1 variable to disable Tor (e.g. if in a transparent proxy environment) then the section is still visible on the left but clicking on it does nothing. It should be hidden when this variable is set to prevent confusion.

added TorBrowserTeam201910R actualpoints::0.2 component::applications/tor browser owner::pospeselr points::0.2 priority::medium resolution::fixed severity::normal status::closed tbb-9.0-issues tbb-9.0.1-can type::defect labels

Trac:
Keywords: N/A deleted, tbb-9.0-issues, tbb-9.0.1-can added

Someone help I cannnot read any website!

extensions.torbutton.use_nontor_proxy true not workingggggggggggggg

Someone help I cannnot read any website!

extensions.torbutton.use_nontor_proxy true not workingggggggggggggg

I don't see how this is at all relevant to this ticket.

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Trac:
Cc: N/A to tbb-team

Small patch to hide/disable the tor page in about:preferences when tor-launcher does not own the tor daemon (ie when using system tor)

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32210

Trac:
Status: assigned to needs_review
Cc: tbb-team to N/A
Keywords: N/A deleted, TorBrowserTeam201910R added

Trac:
Cc: N/A to tbb-team

Just add a checkbox or about:config to completely disable Tor and allow user to use their own proxy configuration(socks/http/pac) like in 8.5.

I had to downgrade TB9 to TB8.5.

Just add a checkbox or about:config to completely disable Tor and allow user to use their own proxy configuration(socks/http/pac) like in 8.5.

The TOR_SKIP_LAUNCH=1 variable does that. This is also irrelevant to this ticket.

The TOR_SKIP_LAUNCH=1 variable does that.

How exactly?

http://ea5faa5po25cf7fb.onion/projects/tor/ticket/32224#comment:5

Replying to pospeselr:

Small patch to hide/disable the tor page in about:preferences when tor-launcher does not own the tor daemon (ie when using system tor)

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_32210

That's a bit of new code added to different places and I would be hesitating just shipping it in 9.0.1. But it seems it's mainly the mechanism used to hide Sync if it is disabled. Thus, this seems already tested quite a bit. So, this looks good to me and works for me, thanks!

I put your code into proper fixup commits, though, this time. Please do it the next time, too (if there is anything that's worth a fixup commit and not a "real" one).

Applied to tor-browser-68.2.0esr-9.5-1 (commit 5d24d4b6873de2da8afa7cba448905522311a4b8) and tor-browser-68.2.0esr-9.0-1 (commit a339c6ec84d612d37eb409eca1b36706a89c9486).

Please add your points.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed
Points: N/A to 0.2

Trac:
Resolution: fixed to N/A
Actualpoints: N/A to 0.2
Status: closed to reopened

Trac:
Resolution: N/A to fixed
Status: reopened to closed

closed

changed time estimate to 1h 36m

added 1h 36m of time spent

moved to tpo/applications/tor-browser#32210 (closed)