Opened 3 months ago

#32230 assigned defect

configure summary is confusing or incorrect

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: 043-must
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

Some of the options in the new configure summary are confusing or incorrect. The configure summary was introduced in #31373.

Wrong place:

  • maybe --enable-systemd should be an optional library?

Inverted, should be --enable-* :

  • --disable-seccomp
  • --disable-libscrypt
  • --disable-gcc-hardening ?
  • --disable-linker-hardening ?
  • --disable-module-dirauth
  • --disable-unittests

Remove Double-Negative ? :

  • assert()s disabled (--disable-asserts-in-tests, dev only): no
    • assert()s enabled (--enable-asserts-in-tests, dev only): yes

Broken:

  • --enable-gcc-warnings:
    • is not Verbose Warnings
    • is an alias for --enable-fatal-warnings, which is already listed
    • did you mean --disable-gcc-warnings-advisory ?
  • --disable-asciidoc
    • also disables manpages and HTML, but they are shown as enabled
  • --enable-fragile-hardening
    • should be true if --enable-expensive-hardening is set, but is shown as false

Missing:

  • --disable-module-relay
    • please build the module feature summary from the list of modules in configure
  • --disable-asciidoc
  • --enable-lzma
  • --enable-zstd
  • --enable-cargo-online-mode
  • --with-tor-user=[user]
  • --with-tor-group=[group]
  • and a few others
  • and a whole bunch of env vars

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.