#32237 closed task (fixed)

Add a Python script to replace C identifiers and generate commit messages

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: teor Sponsor: Sponsor31-can


I sometimes want to replace identifiers in the source code. When I do that, I wind up writing a little perl script, then a shell script to apply that perl script to all the code, and then I write a commit message. But if I'm feeling lazy, I might skip a step, or mix other stuff in with the automated commit. That's not so great.

I've got a script to automate this process.

Child Tickets

Change History (6)

comment:1 Changed 12 months ago by nickm

Actual Points: .1
Milestone: Tor: 0.4.3.x-final
Owner: set to nickm
Status: newaccepted

comment:2 Changed 12 months ago by nickm

Status: acceptedneeds_review

See branch rename_c_identifier with PR in https://github.com/torproject/tor/pull/1457

comment:3 Changed 12 months ago by teor

Reviewer: teor
Status: needs_reviewneeds_revision

Where is the changes file?

There are also a few comments on the PR, I left some, pastly left some.

comment:4 Changed 12 months ago by nickm

I've added fixup! commits to address all the noted issues on the ticket, plus some that dgoulet raised on IRC.

If you'd prefer, I've also made a squashed branch as rename_c_identifier_squashed, PR at https://github.com/torproject/tor/pull/1463

comment:5 Changed 12 months ago by nickm

Status: needs_revisionneeds_review

comment:6 Changed 12 months ago by teor

Resolution: fixed
Sponsor: Sponsor31-can
Status: needs_reviewclosed

I can't find what dgoulet said, but I am happy with these changes.

Merged to master.

Note: See TracTickets for help on using tickets.