Opened 6 weeks ago

Closed 3 weeks ago

#32245 closed enhancement (fixed)

Phase 0: Disable the relay_sys.c entry point in --disable-module-relay

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-november
Cc: nickm Actual Points: 0.1
Parent ID: #31851 Points: 1
Reviewer: nickm Sponsor:

Description

When compiling with --disable-module-relay, we should disable the relay_sys.c entry point.

At each stage, we should work to minimize layer-violations: there should generally not be calls from src/core/ into relay-specific code, and we should plan to refactor as needed to minimize them. We can reduce layer violations in parallel with the above.

Child Tickets

Change History (5)

comment:1 Changed 3 weeks ago by teor

Actual Points: 0.1
Keywords: network-team-roadmap-november added; tor-design network-team-roadmap-october removed
Reviewer: nickm
Status: newneeds_review

See my PR:

It's based on #32244, to avoid conflicts.

comment:2 Changed 3 weeks ago by teor

Summary: Phase 1: Disable the relay_sys.c entry point in --disable-module-relayPhase 0: Disable the relay_sys.c entry point in --disable-module-relay

comment:3 Changed 3 weeks ago by nickm

Status: needs_reviewmerge_ready

LGTM!

comment:4 Changed 3 weeks ago by teor

Owner: set to teor
Status: merge_readyassigned

comment:5 Changed 3 weeks ago by teor

Resolution: fixed
Status: assignedclosed

Merged to master.

Note: See TracTickets for help on using tickets.