Opened 7 weeks ago

Closed 6 weeks ago

Last modified 2 weeks ago

#32250 closed enhancement (fixed)

letterboxing: backport bugzilla 1546832

Reported by: Thorin Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-fingerprinting-resolution, tbb-9.0.1-can, TorBrowserTeam201910R, GeorgKoppen201910, tbb-backported
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description (last modified by Thorin)

https://bugzilla.mozilla.org/show_bug.cgi?id=1546832

Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.

Mozilla's patch also added the findbar, but that seems to already be applied in TB9 [Edit: need moar coffee: that needs fixing too and is in the patch]

[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html

Child Tickets

Change History (8)

comment:1 Changed 7 weeks ago by gk

Keywords: tbb-9.0.1-can TorBrowserTeam201910 added

We might want to squeeze that into 9.0.1, if not then at least test it in 9.5a2.

comment:2 Changed 7 weeks ago by Thorin

Description: modified (diff)

comment:4 Changed 6 weeks ago by gk

Actual Points: 0.1
Keywords: TorBrowserTeam201910R GeorgKoppen201910 added; TorBrowserTeam201910 removed
Points: 0.1
Status: newneeds_review

Thanks! I cherry-picked both patches in my bug_32250 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_32250). Not sure yet whether they should make it directly into 9.0.1 or later into 9.0.2 after baking a bit in 9.5a2.

comment:5 in reply to:  4 Changed 6 weeks ago by Thorin

Replying to gk:

...or later into 9.0.2 after baking a bit in 9.5a2

Let it bake. Stable users are already rattled - let's not introduce the findbar causing letterbox changes too soon

comment:6 Changed 6 weeks ago by mcs

r=brade,r=mcs
The backported patches look good.
Letting this bake a little while in 9.5a2 seems like a good plan to us.

comment:7 in reply to:  6 Changed 6 weeks ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

r=brade,r=mcs
The backported patches look good.
Letting this bake a little while in 9.5a2 seems like a good plan to us.

Yeah, agreed, thanks! Cherry-picked onto tor-browser-68.2.0esr-9.5-1 (commit 8bd51d4e30d4ed1201fab6112ac23f6ddc5858c1 and e10f77aa1b2f91f861841118fa634bbf94429f31). Marking for possible backport.

comment:8 Changed 2 weeks ago by gk

Keywords: tbb-backported added; tbb-backport removed

Landed on the stable branch (tor-browser-68.2.0esr-9.0-1) for 9.0.2 as commits 3d31de7318e3074a4a533b3bfff76a8b84341a4a and 90e3a224b2e9785dafb51263b0bde349c8681a59.

Note: See TracTickets for help on using tickets.