letterboxing: backport bugzilla 1546832

https://bugzilla.mozilla.org/show_bug.cgi?id=1546832

Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.

Mozilla's patch also added the findbar, but that seems to already be applied in TB9 [Edit: need moar coffee: that needs fixing too and is in the patch]

[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html

added GeorgKoppen201910 TorBrowserTeam201910R actualpoints::0.1 component::applications/tor browser ff68-esr owner::tbb-team points::0.1 priority::medium resolution::fixed severity::normal status::closed tbb-9.0.1-can tbb-backported tbb-fingerprinting-resolution type::enhancement labels

We might want to squeeze that into 9.0.1, if not then at least test it in 9.5a2.

Trac:
Keywords: N/A deleted, TorBrowserTeam201910, tbb-9.0.1-can added

Trac:
Description: https://bugzilla.mozilla.org/show_bug.cgi?id=1546832

Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.

Mozilla's patch also added the findbar, but that seems to already be applied in TB9

[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html

to

https://bugzilla.mozilla.org/show_bug.cgi?id=1546832

Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.

Mozilla's patch also added the findbar, but that seems to already be applied in TB9 [Edit: need moar coffee: that needs fixing too and is in the patch]

[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html

There's also https://bugzilla.mozilla.org/show_bug.cgi?id=1556017 from FF69

Thanks! I cherry-picked both patches in my bug_32250 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_32250). Not sure yet whether they should make it directly into 9.0.1 or later into 9.0.2 after baking a bit in 9.5a2.

Trac:
Actualpoints: N/A to 0.1
Points: N/A to 0.1
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R, GeorgKoppen201910 added
Status: new to needs_review

Replying to gk:

...or later into 9.0.2 after baking a bit in 9.5a2

Let it bake. Stable users are already rattled - let's not introduce the findbar causing letterbox changes too soon

r=brade,r=mcs The backported patches look good. Letting this bake a little while in 9.5a2 seems like a good plan to us.

Replying to mcs:

r=brade,r=mcs The backported patches look good. Letting this bake a little while in 9.5a2 seems like a good plan to us.

Yeah, agreed, thanks! Cherry-picked onto tor-browser-68.2.0esr-9.5-1 (commit 8bd51d4e30d4ed1201fab6112ac23f6ddc5858c1 and e10f77aa1b2f91f861841118fa634bbf94429f31). Marking for possible backport.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-backport added

Landed on the stable branch (tor-browser-68.2.0esr-9.0-1) for 9.0.2 as commits 3d31de7318e3074a4a533b3bfff76a8b84341a4a and 90e3a224b2e9785dafb51263b0bde349c8681a59.

Trac:
Keywords: tbb-backport deleted, tbb-backported added

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/applications/tor-browser#32250 (closed)