Opened 9 years ago

Closed 8 years ago

#3227 closed enhancement (fixed)

Orbot notification should be 'ongoing' not 'standard'

Reported by: djhalliday Owned by: n8fr8
Priority: Medium Milestone:
Component: Applications/Orbot Version:
Severity: Keywords:
Cc: gsathya.ceg@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

migrated from github issue #5: https://github.com/guardianproject/Orbot/issues/5

Orbot currently pushes a standard, dismissable notification to the Android system notifications bar when a circuit is established. It is more applicable for remote services such as Orbot to display an ongoing notification instead.

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by ioerror

I just noticed this as well - it should be similar to TextSecure's ongoing status rather than easy to dismiss.

comment:2 Changed 9 years ago by gsathya

Cc: gsathya.ceg@… added
Status: newneeds_review

Added FLAG_ONGOING_EVENT and FLAG_NO_CLEAR so
the notification is not cleared by the user, while
the Service is still running.

https://github.com/gsathya/orbot-sathya/commit/4328475b195760ac4f9f54e204b972e0b0abd23f

If this is fine, I'll just create a patch and attach it to this ticket.

comment:3 Changed 9 years ago by gsathya

I may have jumped the gun here. This is more of a hack than a fix. We probably need to move TorService.java to a full ForegroundService to support ongoing notifications. (I maybe way off base here)

http://blog.radioactiveyak.com/2010/05/when-to-include-exit-button-in-android.html
http://developer.android.com/reference/android/app/Service.html#startForeground(int, android.app.Notification)

comment:4 Changed 8 years ago by n8fr8

Resolution: fixed
Status: needs_reviewclosed

Fixed. Opional ongoing notification working well now in 1.0.8.

Note: See TracTickets for help on using tickets.