Opened 6 weeks ago

Closed 6 weeks ago

Last modified 5 weeks ago

#32284 closed defect (fixed)

No need to save all bundles for mar-signing and authenticode-signing check until we are done

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201910R, GeorgKoppen201910
Cc: Actual Points: 0.1
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

While doing the 9.0 release with it's big incremental .mar files I realized that we keep all the checked files around until the whole check is done essentially doubling the space needed for .mar files which could be too large for folks to properly check them (happened to me).

The same goes in fact for the authenticode signature check.

I think once checked there is no need to keep the checked binary around until the end of the check were it would get deleted anyway.

Child Tickets

Change History (4)

comment:1 Changed 6 weeks ago by gk

Description: modified (diff)

comment:2 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

comment:3 Changed 6 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged it to master as commit 3fe32dbea4f2f21a058b07a367df4f3e6c4e4538, and cherry-picked it to maint-9.0 as commit d9f378d284fb00021a73b72379863169322880e0.

comment:4 Changed 5 weeks ago by gk

Actual Points: 0.1
Note: See TracTickets for help on using tickets.