Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3229 closed defect (fixed)

Make content pref service memory-only + clearable

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: Firefox Patch Issues Version:
Severity: Keywords: MikePerryIteration20110911, tbb-2.2.32-4
Cc: lunar@…, StrangeCharm Actual Points: 1
Parent ID: #2871 Points: 1
Reviewer: Sponsor:

Description

Our current blanket disable of site-specific zoom has very annoying effects on pages like wikipedia. If you zoom to view the text and then click on an anchor link, the zoom gets reset because it is not stored.

We should make this memory only and clearable via an observer or pref.

Child Tickets

Change History (9)

comment:1 Changed 8 years ago by mikeperry

Keywords: MikePerryIterationFires20110529 removed
Priority: normalmajor

comment:2 Changed 8 years ago by lunar

Cc: lunar@… added

comment:3 Changed 8 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable
Points: 1
Summary: Make browser.zoom.siteSpecific memory-onlyMake browser.zoom.siteSpecific memory-only + clearable

Looks like we can easily hack this similar to how we hacked the permissions manager to be memory only. SiteZoom, along with an unknown additional set of 'content' preferences, is stored in a database connection via toolkit/components/contentprefs/nsContentPrefService.js. The database connection is created in _dbInit().

https://developer.mozilla.org/en/XPCOM_Interface_Reference/mozIStorageService

We can also clear some (but perhaps not all?) items from the content-prefs database via removeGroupedPrefs():

https://mxr.mozilla.org/mozilla-central/source/dom/interfaces/base/nsIContentPrefService.idl

That function should clear the site zoom at least.

comment:4 Changed 8 years ago by mikeperry

Summary: Make browser.zoom.siteSpecific memory-only + clearableMake content pref service memory-only + clearable

comment:5 Changed 8 years ago by mikeperry

Keywords: MikePerryIteration20110911 added

comment:6 Changed 8 years ago by mikeperry

Cc: StrangeCharm added

comment:7 Changed 8 years ago by mikeperry

Actual Points: 1

Our patch just hacks the thing to use memory. I would guess Firefox probably wants to make this a prev and a private browsing mode observer.

comment:8 Changed 8 years ago by mikeperry

Resolution: fixed
Status: newclosed

comment:9 Changed 8 years ago by erinn

Keywords: tbb-2.2.32-4 added
Note: See TracTickets for help on using tickets.