Opened 7 months ago

Closed 8 weeks ago

#32301 closed defect (duplicate)

Update Tor GeoIp Files for Android

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam202004
Cc: gk, sysrqb Actual Points:
Parent ID: Points: .25
Reviewer: Sponsor:

Description

Update latest tor config files geoIp, geoIp6 files in tor-android-service

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed

sisbell: the "R" at the end of the keyword is just for indicating the ticket is up for review. If work should be done in a month just use the format without the "R". That said, we probably need to make sure that Tor on Android is using the GeoIP files at all first. So, updating alone is likely not enough.

comment:2 Changed 7 months ago by sysrqb

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201910 removed

As mentioned in #30518, we don't use GeoIP on Android. Tor currently has the default:

  V(GeoIPFile,                   FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
  V(GeoIPv6File,                 FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),

and the current tor binary does not override the default SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in /usr/local/share/tor/geoip (which will never be the case on Android).

We don't need this any time soon because we don't provide a circuit display and we don't provide a way for people to exclude nodes by country code. Is there another use for geoip besides these?

I might actually argue this should be handled after #28766 is complete and we can use the geoip files from tor in tor-browser-build instead of shipping them in both places.

From #28766, we can move them into assets/common in the tor-android-services build file (instead of Data/Tor/geoip{,6} like we do on Linux and Windows).

comment:3 in reply to:  2 ; Changed 7 months ago by sisbell

Replying to sysrqb:

As mentioned in #30518, we don't use GeoIP on Android. Tor currently has the default:

  V(GeoIPFile,                   FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
  V(GeoIPv6File,                 FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),

and the current tor binary does not override the default SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in /usr/local/share/tor/geoip (which will never be the case on Android).

In the case of setting exit nodes, we use the controlConnection. Does setting the geoIp file also not work through the control connection? If it does work, we can still support geoIp.

controlConnection.setConf("GeoIPFile", config.getGeoIpFile().getCanonicalPath());
controlConnection.setConf("GeoIPv6File", config.getGeoIpv6File().getCanonicalPath
                        ());

comment:4 Changed 6 months ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201911 removed

Moving tickets to December

comment:5 Changed 5 months ago by sysrqb

Keywords: TorBrowserTeam202001 added; TorBrowserTeam201912 removed

comment:6 Changed 4 months ago by pili

Keywords: TorBrowserTeam202002 added; TorBrowserTeam202001 removed

Moving tickets to February

comment:7 Changed 3 months ago by pili

Keywords: TorBrowserTeam202003 added; TorBrowserTeam202002 removed

We are no longer in February, moving tickets

comment:8 Changed 2 months ago by pili

Keywords: TorBrowserTeam202004 added; TorBrowserTeam202003 removed

We are no longer in March

comment:9 in reply to:  3 Changed 8 weeks ago by sysrqb

Resolution: duplicate
Status: newclosed

Replying to sisbell:

Replying to sysrqb:

As mentioned in #30518, we don't use GeoIP on Android. Tor currently has the default:

  V(GeoIPFile,                   FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
  V(GeoIPv6File,                 FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),

and the current tor binary does not override the default SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in /usr/local/share/tor/geoip (which will never be the case on Android).

In the case of setting exit nodes, we use the controlConnection. Does setting the geoIp file also not work through the control connection? If it does work, we can still support geoIp.

controlConnection.setConf("GeoIPFile", config.getGeoIpFile().getCanonicalPath());
controlConnection.setConf("GeoIPv6File", config.getGeoIpv6File().getCanonicalPath
                        ());

Ah! I missed that. Thanks for pointing that out. I don't know of a reason why that wouldn't work.

Let's resolve this in #28766.

Note: See TracTickets for help on using tickets.