Opened 7 weeks ago

Last modified 11 days ago

#32301 new defect

Update Tor GeoIp Files for Android

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201912
Cc: gk, sysrqb Actual Points:
Parent ID: Points: .25
Reviewer: Sponsor:

Description

Update latest tor config files geoIp, geoIp6 files in tor-android-service

Child Tickets

Change History (4)

comment:1 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed

sisbell: the "R" at the end of the keyword is just for indicating the ticket is up for review. If work should be done in a month just use the format without the "R". That said, we probably need to make sure that Tor on Android is using the GeoIP files at all first. So, updating alone is likely not enough.

comment:2 Changed 7 weeks ago by sysrqb

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201910 removed

As mentioned in #30518, we don't use GeoIP on Android. Tor currently has the default:

  V(GeoIPFile,                   FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
  V(GeoIPv6File,                 FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),

and the current tor binary does not override the default SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in /usr/local/share/tor/geoip (which will never be the case on Android).

We don't need this any time soon because we don't provide a circuit display and we don't provide a way for people to exclude nodes by country code. Is there another use for geoip besides these?

I might actually argue this should be handled after #28766 is complete and we can use the geoip files from tor in tor-browser-build instead of shipping them in both places.

From #28766, we can move them into assets/common in the tor-android-services build file (instead of Data/Tor/geoip{,6} like we do on Linux and Windows).

comment:3 in reply to:  2 Changed 7 weeks ago by sisbell

Replying to sysrqb:

As mentioned in #30518, we don't use GeoIP on Android. Tor currently has the default:

  V(GeoIPFile,                   FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
  V(GeoIPv6File,                 FILENAME,
    SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),

and the current tor binary does not override the default SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in /usr/local/share/tor/geoip (which will never be the case on Android).

In the case of setting exit nodes, we use the controlConnection. Does setting the geoIp file also not work through the control connection? If it does work, we can still support geoIp.

controlConnection.setConf("GeoIPFile", config.getGeoIpFile().getCanonicalPath());
controlConnection.setConf("GeoIPv6File", config.getGeoIpv6File().getCanonicalPath
                        ());

comment:4 Changed 11 days ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201911 removed

Moving tickets to December

Note: See TracTickets for help on using tickets.