Opened 12 months ago

Last modified 5 months ago

#32335 needs_review task

Set up a .github repository on GitHub

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-github, 043-deferred
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: nickm Sponsor:

Description

Let's set up a GitHub config repository at .github :
https://help.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file-for-your-organization

Then we can:

Child Tickets

Change History (25)

comment:1 Changed 12 months ago by teor

I added https://github.com/torproject/.github and gave the network team push access.

People can now submit pull requests for the files listed above.

comment:3 Changed 9 months ago by rl1987

Status: newneeds_review

comment:4 Changed 9 months ago by ahf

This page is supposed to be "global" and be informative about *all* Tor-related projects we have on github.com/torproject right?

comment:5 in reply to:  4 Changed 9 months ago by teor

Replying to ahf:

This page is supposed to be "global" and be informative about *all* Tor-related projects we have on github.com/torproject right?

Replying to ahf:

This page is supposed to be "global" and be informative about *all* Tor-related projects we have on github.com/torproject right?

Yes, it's global.

So before we merge, we should:

  • check FUNDING with Sarah

And after we merge, we can add other projects to:

  • CONTRIBUTING
  • SECURITY
  • SUPPORT

(Or we could ask them to review this pull request, and add commits. But that might get messy.)

comment:6 in reply to:  4 ; Changed 9 months ago by teor

Status: needs_reviewneeds_revision

I asked for some specific changes to CONTRIBUTING and SUPPORT to allow multiple projects.

comment:7 Changed 9 months ago by ahf

I requested a new URL for the FUNDING section after talking to Sarah.

comment:8 Changed 9 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:9 Changed 9 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: unspecified

comment:10 Changed 9 months ago by rl1987

Status: needs_revisionneeds_review

comment:11 Changed 9 months ago by dgoulet

Reviewer: catalyst

comment:12 Changed 9 months ago by catalyst

Status: needs_reviewmerge_ready

Thanks! It looks like all of the outstanding comments have been addressed. I don't see any obvious problems. I'm not very familiar with the functioning of the .github repository. It seems that we can't really preview its effect on how other repositories in the org look, so we might have to merge it to see?

comment:13 in reply to:  1 ; Changed 9 months ago by catalyst

Replying to teor:

I added https://github.com/torproject/.github and gave the network team push access.

People can now submit pull requests for the files listed above.

Just checking: the github.com copy is authoritative and there is no git.torproject.org repository?

comment:14 in reply to:  13 ; Changed 9 months ago by teor

Replying to catalyst:

Replying to teor:

I added https://github.com/torproject/.github and gave the network team push access.

People can now submit pull requests for the files listed above.

Just checking: the github.com copy is authoritative and there is no git.torproject.org repository?

.github is a GitHub-specific configuration repository.

So I didn't set up a canonical repository on git.torproject.org, and I don't think we need one.

comment:15 in reply to:  14 Changed 9 months ago by catalyst

Replying to teor:

Replying to catalyst:

Replying to teor:

I added https://github.com/torproject/.github and gave the network team push access.

People can now submit pull requests for the files listed above.

Just checking: the github.com copy is authoritative and there is no git.torproject.org repository?

.github is a GitHub-specific configuration repository.

So I didn't set up a canonical repository on git.torproject.org, and I don't think we need one.

Thanks!

Given that this change affects more than the network team, maybe we should ask other teams for objections before merging?

comment:16 Changed 9 months ago by teor

Sure, let's send out an email to tor-project, or the internal list?

It's a shame we can't show people a preview.

comment:17 in reply to:  16 Changed 9 months ago by catalyst

Replying to teor:

Sure, let's send out an email to tor-project, or the internal list?

I'd suggest the internal list, at least initially.

It's a shame we can't show people a preview.

Yeah.

comment:18 in reply to:  16 Changed 9 months ago by catalyst

Status: merge_readyneeds_information

Replying to teor:

Sure, let's send out an email to tor-project, or the internal list?

Sent an email to the internal list a little while ago.

comment:19 in reply to:  6 Changed 9 months ago by teor

Status: needs_informationneeds_revision

Replying to teor:

I asked for some specific changes to CONTRIBUTING and SUPPORT to allow multiple projects.

It's still not clear that the Tor GitHub has multiple projects and teams.

Let's add a sentence at the start that says we have multiple teams, and link to the list of teams on our wiki:
https://trac.torproject.org/projects/tor/wiki/org/teams

After this PR merges, other teams can:

  • add their own sections to CONTRIBUTING and SUPPORT, or
  • override CONTRIBUTING and SUPPORT in their own repositories.

comment:20 Changed 8 months ago by rl1987

Status: needs_revisionneeds_review

comment:21 Changed 6 months ago by asn

Reviewer: catalyst

comment:22 Changed 5 months ago by asn

Reviewer: nickm

comment:23 Changed 5 months ago by teor

I think the license file is wrong, it says:
"Copyright (c) 2019, Tor Project — Unofficial repositories"

Maybe we want to delete it, or copy the one from the tor repository?

comment:24 Changed 5 months ago by nickm

Good catch! The license file isn't part of this PR, though; it looks like github provided it with the initial repository.

Given the history of this ticket, I think our best bet is for me to raise this for more general discussion again and propose a way forward. Namely, I think we should merge the PR, and then fix up whatever remaining issues we find.

I'll bring this up at the all-hands on wednesday and propose that we go ahead that way.

Some issues I would fix post-merge are:

  • Stop recommending trac as a support forum.
  • Explicitly list which repositories are "owned"/maintained by which teams, with a table or list covering every repo we have.

comment:25 Changed 5 months ago by nickm

Sent an email to tor-internal@, giving a last chance to object before we merge, and asking whether we shouldn't just give ownership of this component to the web team.

Note: See TracTickets for help on using tickets.