Use a table to drive options_check_transition and warn_about_relative_paths

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #29211 (moved)
Child Ticket(s): #32338 (moved)

added actualpoints::.1 component::core tor/tor milestone::Tor: 0.4.3.x-final network-team-roadmap-october parent::29211 points::1 priority::medium resolution::fixed reviewer::teor severity::normal sponsor::31-can status::closed type::enhancement labels

See #32344 (moved) for part of this.

I have the relative-path part of this in branch ticket32339_relative with PR at https://github.com/torproject/tor/pull/1487

Trac:
Reviewer: N/A to teor
Status: new to needs_review
Actualpoints: N/A to .1

Looks fine, but should we also be checking file Logs here?

Trac:
Status: needs_review to needs_revision

We should, but that's harder and I don't know a good way to do it. Any ideas?

We should be able to loop through Logs like we do HiddenServiceDir? Maybe we'll need to do that after we've parsed Logs into log objects. I'll see if I can write some code for it.

One challenge with looping over logs is that we only want to look at the filenames. We'd also want to look at filenames inside FooPort options

My eventual hope with Logs and Ports is that we can reuse the control-command parsing code in control_cmd.c to break them into their own options objects, and handle those with the regular configuration processing code.

Do you think that, for now, we might be able to take this patch as a straightforward refactoring, and add additional checks in a separate branch? For me it is a blocker for #30866 (moved), and I'd like to get that straightened out.

Trac:
Status: needs_revision to needs_review

(Rationale for proceeding: I believe that this branch is a strict improvement over Tor's current behavior, doesn't introduce technical debt, and unblocks #30866 (moved). If you don't agree, we shouldn't proceed.)

Yes, I think we should go ahead, and make further changes in other tickets.

I'd like to merge #32213 (moved), #32339 (moved), and #32344 (moved) in that order, to minimise conflicts (if any). I'm just waiting for CI to pass on #32213 (moved).

Trac:
Status: needs_review to merge_ready

Merged #32213 (moved), #32339 (moved), and #32344 (moved).

Resolved conflicts between #32339 (moved) and #32344 (moved) by taking the V_IMMUTABLE and FILENAME changes on PidFile.

Opened #32373 (moved) for follow up.

Trac:
Keywords: network-team-roadmap-? deleted, network-team-roadmap-october added
Resolution: N/A to fixed
Status: merge_ready to closed