Opened 4 months ago

Closed 4 months ago

#32352 closed defect (fixed)

Stop adding a space when dumping an empty config value

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: BugSmashFund, no-backport
Cc: nickm Actual Points: 0.1
Parent ID: #32213 Points: 0.1
Reviewer: Sponsor:

Description

We unconditionally add a space when dumping torrc files, even if there is no option value. (Which is rare, but does happen with some list options.)

The extra space is unnecessary and we should remove it.

This bug has been around since Tor 0.0.9pre6.

The fix is in this commit, I need to extract it and add a changes file:
https://github.com/torproject/tor/pull/1477/commits/67d0178f1aba0a424364acc1c9f9dff2c72886a4

Child Tickets

Change History (3)

comment:1 Changed 4 months ago by teor

Status: assignedneeds_revision

comment:2 Changed 4 months ago by teor

We'll deal with these changes in #32213.

comment:3 Changed 4 months ago by teor

Resolution: fixed
Status: needs_revisionclosed
Note: See TracTickets for help on using tickets.