Opened 12 months ago

Last modified 8 months ago

#32360 new defect

Rethink fix for #31564

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202006, fenixmigration
Cc: sisbell Actual Points:
Parent ID: Points: 1.5
Reviewer: Sponsor:

Description

In #31564 we added a step in the building process for Android where the apk is unzipped and then rezipped. This provided an easy way for normalizing the ordering of files in the archive.

Unfortunately, rezipping all files results in files being compressed differently. #32342 is an unfortunate side-effect of this, where omni.ja was compressed a second time when it was added into the apk. That ticket shows significant changes between how files were added in the original apk verses how they are added in the rezipped apk. We don't know if there are more/different bugs lurking now.

We should look closer at how Mozilla modify the apk. They have a custom jar thing.

Child Tickets

Change History (9)

comment:1 Changed 12 months ago by sisbell

The idea behind ApkTool was a quick fix for repro but its starting to look like it may have more problems than its worth. If we can just do the aapt compile for resources directly, then use the package script in the firefox project, it should work.

I had done the aapt compile of resources when first investigating the repo issue. It didn't quite work due to some missing resources. The app would crash in runtime. I'd need to spend some time to track all the resources down.

comment:2 Changed 12 months ago by pili

Points: 1.5

comment:3 Changed 11 months ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201911 removed

Moving tickets to December

comment:4 Changed 10 months ago by sysrqb

Keywords: TorBrowserTeam202001 added; TorBrowserTeam201912 removed

comment:5 Changed 9 months ago by pili

Keywords: TorBrowserTeam202002 added; TorBrowserTeam202001 removed

Moving tickets to February

comment:6 Changed 8 months ago by sysrqb

Deferring some more tickets from February 2020 to June 2020. Too many tickets, not enough time.

comment:7 Changed 8 months ago by sysrqb

Keywords: TorBrowserTeam202006 added; TorBrowserTeam202002 removed

Second attempt at deferring tickets until June.

comment:8 Changed 8 months ago by sysrqb

Keywords: ReleaseTrainMigration added

comment:9 Changed 8 months ago by sysrqb

Keywords: fenixmigration added; ReleaseTrainMigration removed
Note: See TracTickets for help on using tickets.