Opened 4 months ago

Closed 3 weeks ago

Last modified 2 weeks ago

#32372 closed enhancement (implemented)

Add a practracker mode that only regenerates over-broad exceptions

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-should
Cc: nickm, asn Actual Points: .2
Parent ID: Points: 1
Reviewer: ahf Sponsor:

Description

In #32213, I regenerated the practracker file, and then manually committed the over-broad exceptions.

It would be helpful if we had a --regen-overbroad option to practracker, that automatically regenerated the improvements we have made.

I feel like this should be easy, it's a combination of --regen and --list-overbroad. But I don't know the practracker design well enough to do it cleanly.

Child Tickets

Change History (10)

comment:1 Changed 5 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 4 weeks ago by gaba

Sponsor: Sponsor31-can

No more sponsor 31. All this tickets remained open after sponsor 31 ended.

comment:3 Changed 3 weeks ago by nickm

See branch practracker_regen_overbroad_2 with PR at https://github.com/torproject/tor/pull/1705 . It includes an integration test for --regen-overbroad, as well as one for --regen.

comment:4 Changed 3 weeks ago by nickm

Status: acceptedneeds_review

Travis has passed. Appveyor found an issue with --regen and --regen-overbroad on windows; I've added another commit to address that one.

comment:5 Changed 3 weeks ago by nickm

Actual Points: .2

comment:6 Changed 3 weeks ago by nickm

(CI is now passing)

comment:7 Changed 3 weeks ago by ahf

Reviewer: ahf

comment:8 Changed 3 weeks ago by ahf

Status: needs_reviewmerge_ready

This looks good.

comment:9 Changed 3 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

ok, merged to master.

comment:10 Changed 2 weeks ago by teor

Thanks so much!

Note: See TracTickets for help on using tickets.