Changes between Version 1 and Version 2 of Ticket #32380, comment 5


Ignore:
Timestamp:
Feb 28, 2020, 10:19:01 AM (7 months ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32380, comment 5

    v1 v2  
    47471608326 (patch 1 + 2 + 3)                          (okay to leave out)
    4848}}}
    49 "x" denotes all the commits I included. "(okay to leave out)" is basically for those that change things into Mozilla's way of providing binaries like `lucetc` in their taskcluster setup, which we don't need (we build our stuff in `tor-browser-build`). "(can skip)" are excluded to reduce the pile of commits as much as possible by skipping intermediate repo updates as they landed on `mozilla-central`. We use the final one instead, so that we are landing on the right revisions without including the intermediary steps.
     49"x" denotes all the commits I included. "(okay to leave out)" is basically for those that change things in Mozilla's way of providing binaries like `lucetc` in their taskcluster setup, which we don't need (we build our stuff in `tor-browser-build`). "(can skip)" are excluded to reduce the pile of commits as much as possible by skipping intermediate repo updates as they landed on `mozilla-central`. We use the final one instead, so that we are landing on the right revisions without including the intermediary steps.
    5050
    5151I needed to add [https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_32380_v11&id=b6d405a0495c5d379ac849494b1ed5cdd877ce32 two] [https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_32380_v11&id=53d7cd020e03b9857093afc0889f58f4829ed802 additional] commits on top of those to fix two compilation bustages: one because of a bug in `rlbox_lucet_sandbox` uncovered by our toolchain and the other is a backport of a fix that landed in bug 1595617. The latter, however, does not apply cleanly as it is based on a series of patches which landed in bug 1547603, which we very likely don't want to backport. My testing suggests we are good, but we should double-check that or mabye just provide an alternative workaround instead of backporting the fix for bug 1595617.