Opened 9 months ago

Last modified 2 months ago

#32389 needs_revision task

Sandbox Graphite using RLBox for Linux

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security, GeorgKoppen202006, TorBrowserTeam202006
Cc: tbb-team Actual Points:
Parent ID: #34228 Points:
Reviewer: Sponsor:

Description

We should try to sandbox Graphite using RLBox as a prototype gathering some performance and overhead data and helping to decide in which direction we want to go further on.

Child Tickets

TicketStatusOwnerSummaryComponent
#32380closedgkGet current Tor Browser code ready for RLBoxApplications/Tor Browser
#32434closedtbb-teamGet build changes needed for RLBox into tor-browser-buildApplications/Tor Browser

Change History (13)

comment:1 Changed 8 months ago by gk

Keywords: GeorgKoppen201912 added; GeorgKoppen201911 removed

Moving my tickets to December.

comment:2 Changed 7 months ago by gk

Keywords: GeorgKoppen202001 added; GeorgKoppen201912 removed

No December anymore.

comment:3 Changed 7 months ago by gk

Keywords: GeorgKoppen202002 added; GeorgKoppen202001 removed

Move my tickets to Feb 2020.

comment:4 Changed 6 months ago by gk

Summary: Sandbox Graphite using RLBoxSandbox Graphite using RLBox for Linux

comment:5 Changed 6 months ago by gk

Cc: tbb-team added
Owner: changed from tbb-team to gk
Status: newassigned

comment:6 Changed 6 months ago by gk

Keywords: TorBrowserTeam202002R added
Status: assignedneeds_review

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

An additional thing to note: I had to install git to apply the one huge patch for a couple of reasons. For one, patch on Wheezy does not cope with git renaming patches. That feature is only starting with version 2.7 but the one on Wheezy 2.6.1 (backports did not seem to change that story). Then I thought, okay, let's do git format-patch --no-renames instead and use the larger patch with patch. The problem now is that patch does not deal with empty files (it does not create them) which breaks the build. I then decided to resort to git apply and just added git as a dependency to all the other ones for Linux x86_64 to not just create a container for RLBox and have further container inflation.

comment:7 Changed 6 months ago by pili

Keywords: TorBrowserTeam202003R added; TorBrowserTeam202002R removed

We are no longer in February moving reviews

comment:8 in reply to:  6 ; Changed 5 months ago by boklm

Keywords: TorBrowserTeam202003 added; TorBrowserTeam202003R removed
Status: needs_reviewneeds_revision

Replying to gk:

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

I think the patches should be generated with git format-patch -N.

Currently all patches contain [PATCH n/m] in the subject, where m is the total number of patches. This means that adding new patches (like in #33410) will require changing all patches to update m. I think using the -N option would avoid that.

comment:9 in reply to:  8 Changed 5 months ago by gk

Keywords: GeorgKoppen202003 TorBrowserTeam202003R added; GeorgKoppen202002 TorBrowserTeam202003 removed
Status: needs_revisionneeds_review

Replying to boklm:

Replying to gk:

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

I think the patches should be generated with git format-patch -N.

Currently all patches contain [PATCH n/m] in the subject, where m is the total number of patches. This means that adding new patches (like in #33410) will require changing all patches to update m. I think using the -N option would avoid that.

Well, I don't think that we need to update patches often, so I don't think that's a big issue. But I don't care strongly here, so I just did as you suggested: bug_33410_v5 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33410_v5&id=6c8d666b6de4f4ecd531a77d89806f459231e2df) has the updated patch.

comment:10 Changed 5 months ago by pili

Keywords: TorBrowserTeam202004R added; TorBrowserTeam202003R removed

We are no longer in March

comment:11 Changed 4 months ago by pili

Reviewer: pospeselr

comment:12 Changed 2 months ago by gk

Keywords: GeorgKoppen202006 TorBrowserTeam202006 added; GeorgKoppen202003 TorBrowserTeam202004R removed
Reviewer: pospeselr
Status: needs_reviewneeds_revision

comment:13 Changed 2 months ago by gk

Parent ID: #32379#34228
Note: See TracTickets for help on using tickets.