Sandbox Graphite using RLBox for Linux

We should try to sandbox Graphite using RLBox as a prototype gathering some performance and overhead data and helping to decide in which direction we want to go further on.

Trac:
Parent Ticket: #34228 (moved)
Child Ticket(s): #32434 (moved), #32380 (moved)

added GeorgKoppen202006 TorBrowserTeam202006 component::applications/tor browser owner::gk parent::34228 priority::medium severity::normal status::needs-revision tbb-security type::task labels

Moving my tickets to December.

Trac:
Keywords: GeorgKoppen201911 deleted, GeorgKoppen201912 added

No December anymore.

Trac:
Keywords: GeorgKoppen201912 deleted, GeorgKoppen202001 added

Move my tickets to Feb 2020.

Trac:
Keywords: GeorgKoppen202001 deleted, GeorgKoppen202002 added

Trac:
Summary: Sandbox Graphite using RLBox to Sandbox Graphite using RLBox for Linux

Trac:
Owner: tbb-team to gk
Status: new to assigned
Cc: N/A to tbb-team

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 (moved) into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

An additional thing to note: I had to install git to apply the one huge patch for a couple of reasons. For one, patch on Wheezy does not cope with git renaming patches. That feature is only starting with version 2.7 but the one on Wheezy 2.6.1 (backports did not seem to change that story). Then I thought, okay, let's do git format-patch --no-renames instead and use the larger patch with patch. The problem now is that patch does not deal with empty files (it does not create them) which breaks the build. I then decided to resort to git apply and just added git as a dependency to all the other ones for Linux x86_64 to not just create a container for RLBox and have further container inflation.

Trac:
Keywords: N/A deleted, TorBrowserTeam202002R added
Status: assigned to needs_review

We are no longer in February moving reviews

Trac:
Keywords: TorBrowserTeam202002R deleted, TorBrowserTeam202003R added

Replying to gk:

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 (moved) into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

I think the patches should be generated with git format-patch -N.

Currently all patches contain [PATCH n/m] in the subject, where m is the total number of patches. This means that adding new patches (like in #33410 (moved)) will require changing all patches to update m. I think using the -N option would avoid that.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam202003R deleted, TorBrowserTeam202003 added

Replying to boklm:

Replying to gk:

bug_32389_v8 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32389_v8&id=6402b4ce975647e263611c49183456930dae461b) has the patch for review which is enabling RLBox for Graphite on Linux x86_64.

As we talked on IRC I've included all the patches I backported in #32380 (moved) into a separate directory, rlbox-patches, in the firefox project. The commit message explains a bit why.

I think the patches should be generated with git format-patch -N.

Currently all patches contain [PATCH n/m] in the subject, where m is the total number of patches. This means that adding new patches (like in #33410 (moved)) will require changing all patches to update m. I think using the -N option would avoid that.

Well, I don't think that we need to update patches often, so I don't think that's a big issue. But I don't care strongly here, so I just did as you suggested: bug_33410_v5 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33410_v5&id=6c8d666b6de4f4ecd531a77d89806f459231e2df) has the updated patch.

Trac:
Status: needs_revision to needs_review
Keywords: GeorgKoppen202002, TorBrowserTeam202003 deleted, TorBrowserTeam202003R, GeorgKoppen202003 added

We are no longer in March

Trac:
Keywords: TorBrowserTeam202003R deleted, TorBrowserTeam202004R added

Trac:
Reviewer: N/A to pospeselr

Trac:
Reviewer: pospeselr to N/A
Keywords: TorBrowserTeam202004R, GeorgKoppen202003 deleted, GeorgKoppen202006, TorBrowserTeam202006 added
Status: needs_review to needs_revision

Trac:
Parent: #32379 (moved) to #34228 (moved)

mentioned in issue #32434 (moved)

mentioned in issue #32380 (moved)

mentioned in issue #34228 (moved)

moved to tpo/applications/tor-browser-build#32389 (closed)