Opened 7 months ago

Closed 5 months ago

#32393 closed defect (fixed)

GetTor's GitHub links are broken

Reported by: dcf Owned by:
Priority: Medium Milestone:
Component: Applications/GetTor Version:
Severity: Normal Keywords: github
Cc: traumschule, hiro, gaba, phw, cohosh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I just requested a gettor@torproject.org email. The github.com links in the response are broken:

Tor Browser 8.5.5 for windows-en-US-64 (github): https://github.com/TheTorProject/gettorbrowser/raw/torbrowser-releases/torbrowser-install-8.5.5_en-US.exe
Signature file: https://github.com/TheTorProject/gettorbrowser/raw/torbrowser-releases/torbrowser-install-8.5.5_en-US.exe.asc

The current version of the branch that should hold the downloads is https://github.com/TheTorProject/gettorbrowser/tree/d3b2871c6b92db792e169cfb146cae358729ee30. It doesn't seem to hold any download files at all, only .gitattributes and README.md.

Looking at past commits, there were sometimes some files present, but never a complete set:

Child Tickets

Change History (6)

comment:1 Changed 7 months ago by cohosh

Looks like the gettorbrowser github repo mirrors the gitlab version up to this commit

But then is missing the rest of the dist ci commits.

The reason for a partial set is because the release files are added one commit at a time. So it looks like something went wrong part way through the github update (the update was reset with this commit), and then wasn't started or re-run for the github remote.

comment:2 Changed 6 months ago by cohosh

Gettor was recently moved to a new host and the repositories need to be set up again. Here are some steps I did this morning to set up the github/gitlab repositories on gettor-01:

$ sudo -u gettor -s git init
$ sudo -u gettor -s git remote add github git@github.com:TheTorProject/gettorbrowser.git
$ sudo -u gettor -s git remote add origin git@gitlab.com:thetorproject/gettorbrowser.git
$ sudo -u gettor -s git fetch origin
$ sudo -u gettor -s git fetch github

And then I ran the update_files script with sudo -u gettor -s ./update_files and received the following errors:

batch response: Your push has been rejected, because this repository has exceeded its size limit of 9.8 GB by 66 MB. Please contact your GitLab administrator for more information.
error: failed to push some refs to 'git@gitlab.com:thetorproject/gettorbrowser.git'
batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
error: failed to push some refs to 'git@github.com:TheTorProject/gettorbrowser.git'

So it seems that the script as it is currently written will not update the gitlab or github repos. This might be why we had an incomplete upload before.

comment:3 Changed 6 months ago by cohosh

It looks like even deleting the torbrowser-releases branch doesn't reduce the repository size.

Looks like #32480 will be necessary for moving forward with this.

comment:4 in reply to:  3 ; Changed 6 months ago by arma

Replying to cohosh:

It looks like even deleting the torbrowser-releases branch doesn't reduce the repository size.

As said just now also on #32480: It does seem like deleting the git branch won't reduce the repo size. It's equivalent to deleting a pointer to a commit -- all the commits will still be there.

If we want to make the old approach work on github/gitlab, we probably want to throw out the repo periodically and then put new tor browser files into a fresh repo.

comment:5 in reply to:  4 Changed 6 months ago by cohosh

Replying to arma:

If we want to make the old approach work on github/gitlab, we probably want to throw out the repo periodically and then put new tor browser files into a fresh repo.

I would argue that we don't want to do it the old way. In addition to size constraints, we also have bandwidth constraints: https://help.github.com/en/github/managing-large-files/about-storage-and-bandwidth-usage

If I'm understanding these correctly, only a hand full of users will actually be able to download one of our gettorbrowser binaries before we reach our limit and nobody can download anything from the repo anymore. Luckily, releases don't count against either storage or bandwidth limits (at least for github). So I think #32480 is the way to go.

comment:6 Changed 5 months ago by cohosh

Resolution: fixed
Status: newclosed

This has now been fixed by #32480 and a recent update.

Note: See TracTickets for help on using tickets.