Opened 3 months ago

Closed 3 months ago

#32397 closed enhancement (implemented)

Add lzma, nss, and zstd support to test_parseconf.sh

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-november
Cc: nickm, teor, gaba Actual Points: 0.3
Parent ID: #29211 Points: 1
Reviewer: nickm Sponsor: Sponsor31-can

Description (last modified by teor)

We want to allow files like "expected_nss_no_relay_dirauth", for cases where the outputs differ.

Child Tickets

TicketTypeStatusOwnerSummary
#32401defectclosedteorFix variable typos in configure's lzma and zstd support
#32402defectclosedteorActually check most shell scripts for errors

Change History (3)

comment:1 Changed 3 months ago by teor

Actual Points: 0.3
Description: modified (diff)
Reviewer: nickm
Status: assignedneeds_review
Summary: Add NSS and rust support to test_parseconf.shAdd lzma, nss, and zstd support to test_parseconf.sh

See my PR:

Hi Nick,
You can test NSS builds using:

  • one of expected_nss or error_nss, and
  • one of expected or error.

Detailed documentation is in the script.

comment:2 Changed 3 months ago by teor

CI failed due to shellcheck, that shouldn't happen now that #32402 is merged.
(My debian has a newer shellcheck than our CI, so I might find a few more shellcheck issues.)

comment:3 Changed 3 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Looks good to me. Merging.

Note: See TracTickets for help on using tickets.